Wire JSON ingestion schema extension modules#1215
Open
jwils wants to merge 1 commit into
Open
Conversation
3436470 to
ea857eb
Compare
b80bef4 to
bce83e3
Compare
ea857eb to
7af1788
Compare
bce83e3 to
38d7488
Compare
38d7488 to
65c8468
Compare
7af1788 to
20ee5dd
Compare
65c8468 to
d780944
Compare
5b67eda to
28d3b58
Compare
08fa741 to
66a50ff
Compare
4f85649 to
fd4651f
Compare
e904b45 to
7cd0f7d
Compare
2e3770f to
9ed0d47
Compare
3d879aa to
01d66b2
Compare
9ed0d47 to
a02256c
Compare
01d66b2 to
4d549ec
Compare
a02256c to
180c7d3
Compare
180c7d3 to
cd6256d
Compare
myronmarston
requested changes
May 31, 2026
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
I haven't finished reviewing but wanted to submit my feedback so far.
55175c5 to
16255f2
Compare
myronmarston
requested changes
May 31, 2026
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
Still not done reviewing but here's my next round of feedback.
738964b to
57c341a
Compare
This was referenced Jun 1, 2026
myronmarston
reviewed
Jun 1, 2026
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
Next set of feedback (still not done reviewing!).
e28ff9c to
83f6c2a
Compare
myronmarston
requested changes
Jun 2, 2026
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
Made it through the end of my review this time! Almost ready.
caeab86 to
700dc21
Compare
700dc21 to
8f06402
Compare
myronmarston
approved these changes
Jun 5, 2026
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Introduce the JSON ingestion schema-definition extension modules after the indexing extension points exist, but before making JSON ingestion the default implementation.
What
ElasticGraph::JSONIngestion::SchemaDefinition::APIExtensionand supporting factory/results/artifact/state/schema-element extension modulesRisk Assessment
Medium - this adds new extension code, but the default behavior remains the existing core JSON Schema implementation in this PR.
References
bundle exec rspec elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_field_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/indexing/json_schema_with_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/factory_spec.rbpassed.script/type_checkpassed.script/lintpassed.Stack
Current PR is marked with
->.