Rename DatastoreQuery#search_index_definitions to initial_search_index_definitions#1253
Merged
Merged
Conversation
…x_definitions. The new name better conveys intent: these are the index definitions provided at construction time, before any query-time refinement. This lays the groundwork for introducing a separate `narrowed_search_index_definitions` that will be used only when building the search index expression. Generated with Claude Code
marcdaniels-toast
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwils,
jwondrusch,
myronmarston and
rossroberts-toast
as code owners
myronmarston
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spun out of #1229 to ease review. This is just a rename; there are intentionally no behavior changes.
Renames the
DatastoreQueryfieldsearch_index_definitionstoinitial_search_index_definitionsacross all callers and tests, and adds a YARD doc describing it as "the index definitions as provided at construction, before any subsequent adjustments."The new name sets up a clear contrast with
narrowed_search_index_definitionsintroduced in #1229, which derives a refined set based on query filters.Note
This could be a breaking change for ElasticGraph application maintainers, if their
application has any query interceptors that reference
query.search_index_definitions.The next release will need to be minor version bump (
v1.3.0) and this should becalled out in the upgrade section of the release notes.
🤖 Generated with Claude Code