Skip to content

Update client dependencies#445

Open
rongxin-liu wants to merge 3 commits into
mainfrom
rongxin/update-client-deps
Open

Update client dependencies#445
rongxin-liu wants to merge 3 commits into
mainfrom
rongxin/update-client-deps

Conversation

@rongxin-liu

@rongxin-liu rongxin-liu commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updates client npm dependency pins and regenerates client/package-lock.json.
  • Refreshes React/React Router, Connect RPC, Storybook, Tailwind, ESLint, Prettier, and related tooling packages.
  • Adds an esbuild@0.28.1 override so the resolved dependency tree passes npm audit without downgrading Storybook.

Validation

  • source bin/activate-hermit && just gen
  • source bin/activate-hermit && just format
  • cd client && ../bin/npm audit --audit-level=low
  • cd client && ../bin/npm ls esbuild
  • cd client && ../bin/npm run build
  • cd client && ../bin/npx vitest run
  • cd client && ../bin/npm run build-storybook
  • git push pre-push hook: client typecheck

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code client labels Jun 14, 2026
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

  • Reviewed pull request diff only (75933fce45c269e41e0ba2b30cd33825b0389fa7...1792560c0db0608e147a05e08fe416547316d56d, exact PR three-dot diff)
  • Model: gpt-5.5

💡 Click "edited" above to see previous reviews for this PR.


Review Summary

Overall Risk: LOW

Findings

[LOW] Global esbuild override bypasses Storybook’s declared compatibility range

  • Category: Reliability
  • Location: client/package.json:93
  • Description: The new top-level esbuild override forces all transitive consumers to 0.28.1. In the resulting lockfile, storybook@10.4.4 still declares esbuild only through ^0.27.0, and npm --prefix client ls esbuild --package-lock-only --all reports Storybook using esbuild@0.28.1 overridden.
  • Impact: Storybook dev/build may fail after a clean install if Storybook relies on esbuild behavior from its declared supported range. This primarily affects npm run storybook, npm run build-storybook, and any CI covering those scripts.
  • Recommendation: Remove the global override or scope it only to packages that declare compatibility with 0.28.x. If the override is intentional, verify with a clean install plus npm run build-storybook and npm run build.

Notes

Review scope was limited to .git/codex-review.diff, which only changes client/package.json and client/package-lock.json. I did not find auth, SQLi, command injection, network discovery, plugin-boundary, cryptostealing/pool-hijack, infrastructure, Rust, Python, or protobuf changes in this PR diff.


Generated by Codex Security Review |
Triggered by: @rongxin-liu |
Review workflow run

@rongxin-liu rongxin-liu changed the title [codex] Update client dependencies Update client dependencies Jun 14, 2026
@rongxin-liu rongxin-liu marked this pull request as ready for review June 14, 2026 18:51
@rongxin-liu rongxin-liu requested a review from a team as a code owner June 14, 2026 18:51
Copilot AI review requested due to automatic review settings June 14, 2026 18:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants