Clarify default worker name display#457
Conversation
🔐 Codex Security Review
Review SummaryOverall Risk: NONE FindingsNo security, correctness, or reliability findings in the reviewed diff. NotesThe changes are limited to the ProtoFleet miner list worker-name display, a tooltip marker for default MAC-derived worker names, and a narrowly used shared I did not run tests; this review was based on Generated by Codex Security Review | |
There was a problem hiding this comment.
Pull request overview
This PR updates the ProtoFleet miners table “Worker name” rendering to better explain and de-emphasize MAC-derived fallback values (especially for BitAxe/asic-rs), and adds a small List rendering capability to allow tooltip content to escape the cell.
Changes:
- Add a default-worker-name indicator + tooltip when the worker name appears to be MAC-derived.
- Hide MAC-derived worker names for
AUTHENTICATION_NEEDEDminers so the cell is empty until Fleet can authenticate. - Extend the shared
Listcolumn config withallowOverflowto support tooltips that shouldn’t be clipped by cell truncation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/shared/components/List/types.ts | Adds allowOverflow?: boolean to column config types. |
| client/src/shared/components/List/List.tsx | Implements overflow class selection to support overflow-visible columns. |
| client/src/protoFleet/features/fleetManagement/components/MinerList/MinerWorkerName.tsx | Adds MAC-derived detection, tooltip display, and auth-needed hiding logic. |
| client/src/protoFleet/features/fleetManagement/components/MinerList/MinerWorkerName.test.tsx | Adds coverage for default-marker, tooltip text, and auth-needed hiding behavior. |
| client/src/protoFleet/features/fleetManagement/components/MinerList/minerColConfig.tsx | Enables overflow for the worker-name column and adjusts its width. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65d107667e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Summary
Test plan
Closes #83