Skip to content

Clarify default worker name display#457

Merged
negarn merged 4 commits into
mainfrom
negar/gh-83-clarify-bitaxe-worker-name-default
Jun 15, 2026
Merged

Clarify default worker name display#457
negarn merged 4 commits into
mainfrom
negar/gh-83-clarify-bitaxe-worker-name-default

Conversation

@negarn

@negarn negarn commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Clarify MAC-derived worker names by showing an info tooltip for paired miners using the default fallback
image
  • Show an empty Worker name cell for authentication-required miners until Fleet can authenticate and read the value
image
  • Allow the worker-name tooltip to escape the table cell without changing other columns

Test plan

  • Confirm paired miners with MAC-derived worker names show the info tooltip in the Worker name column
  • Confirm authentication-required miners show an empty Worker name cell
  • Confirm custom worker names still render without the default tooltip

Closes #83

Copilot AI review requested due to automatic review settings June 15, 2026 16:10
@negarn negarn requested a review from a team as a code owner June 15, 2026 16:10
@github-actions github-actions Bot added javascript Pull requests that update javascript code client labels Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

  • Reviewed pull request diff only (45a10bc28c37f66376e61ebce1fe33d07f5757cc...15f3283b886c32fdb093a775aa8d434a6b4729de, exact PR three-dot diff)
  • Model: gpt-5.5

💡 Click "edited" above to see previous reviews for this PR.


Review Summary

Overall Risk: NONE

Findings

No security, correctness, or reliability findings in the reviewed diff.

Notes

The changes are limited to the ProtoFleet miner list worker-name display, a tooltip marker for default MAC-derived worker names, and a narrowly used shared List overflow option. I did not see changes touching auth, backend RPC, SQL, discovery, plugins, pool configuration, command execution, infrastructure, or protobuf wire format.

I did not run tests; this review was based on .git/codex-review.diff and surrounding source context only.


Generated by Codex Security Review |
Triggered by: @negarn |
Review workflow run

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ProtoFleet miners table “Worker name” rendering to better explain and de-emphasize MAC-derived fallback values (especially for BitAxe/asic-rs), and adds a small List rendering capability to allow tooltip content to escape the cell.

Changes:

  • Add a default-worker-name indicator + tooltip when the worker name appears to be MAC-derived.
  • Hide MAC-derived worker names for AUTHENTICATION_NEEDED miners so the cell is empty until Fleet can authenticate.
  • Extend the shared List column config with allowOverflow to support tooltips that shouldn’t be clipped by cell truncation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
client/src/shared/components/List/types.ts Adds allowOverflow?: boolean to column config types.
client/src/shared/components/List/List.tsx Implements overflow class selection to support overflow-visible columns.
client/src/protoFleet/features/fleetManagement/components/MinerList/MinerWorkerName.tsx Adds MAC-derived detection, tooltip display, and auth-needed hiding logic.
client/src/protoFleet/features/fleetManagement/components/MinerList/MinerWorkerName.test.tsx Adds coverage for default-marker, tooltip text, and auth-needed hiding behavior.
client/src/protoFleet/features/fleetManagement/components/MinerList/minerColConfig.tsx Enables overflow for the worker-name column and adjusts its width.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65d107667e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@negarn negarn changed the title Clarify BitAxe default worker name display Clarify default worker name display Jun 15, 2026
@negarn negarn merged commit 3f14d37 into main Jun 15, 2026
77 checks passed
@negarn negarn deleted the negar/gh-83-clarify-bitaxe-worker-name-default branch June 15, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(bitaxe): BitAxe uses wrong worker name

3 participants