feat: add ListMysqlDatabases endpoint #113
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new API endpoint for listing configured MySQL databases from SchemaBot’s server configuration.
Changes:
- Defines response types for MySQL database inventory.
- Registers and implements
GET /api/mysql/databaseswith optional environment filtering. - Adds handler tests and updates API README route documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/apitypes/apitypes.go |
Adds response structs for MySQL database inventory. |
pkg/api/service.go |
Registers the new MySQL database listing route. |
pkg/api/README.md |
Documents the new route and handler file. |
pkg/api/mysql_handlers.go |
Implements the MySQL database inventory handler and filtering logic. |
pkg/api/mysql_handlers_test.go |
Adds tests for listing, filtering, and empty configuration behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Triage review of this draft, which has been open a while — sharing an honest assessment of where it stands relative to the current codebase:
Given the schema-pull/onboarding primitives now landing (#313), the recommendation is to close this and re-approach the need as an engine-agnostic database listing on top of that work. Happy to discuss if there's a use case the generic shape wouldn't cover. 🤖 This review was generated by Claude Code (claude-fable-5) with maintainer approval. |
Create new endpoint for use by metanexus.
This lists all mysql databases.
ref: https://linear.app/squareup/issue/DFNS-445/create-schemabot-endpoint-listmysqldatabases