feat(storage): drop the legacy halt_on_failure column#338
Merged
Conversation
Patch 2 of the on_failure migration. #317 moved all code to the on_failure enum and kept halt_on_failure additively so in-flight old pods were unaffected; nothing reads the column now, so remove it. Must deploy only after the on_failure code is fully rolled out.
There was a problem hiding this comment.
Pull request overview
Removes the legacy halt_on_failure column from the MySQL apply_operations table schema as the final step of the halt_on_failure → on_failure migration, relying on startup-time schema reconciliation to emit the DROP COLUMN.
Changes:
- Drop
halt_on_failurefrompkg/schema/mysql/apply_operations.sql.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
aparajon
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why ?
Patch 2 of the two-step
halt_on_failure→on_failuremigration: removes the now-unusedhalt_on_failurecolumn fromapply_operations. The earlier patch added theon_failureenum and moved all config/storage/claim-predicate code onto it while keeping the old column
additively, so in-flight pods running the previous code were unaffected. Nothing reads the
column anymore, so it can be removed.
EnsureSchemareconciles the embedded schema via the Spirit differ on startup, so thisemits the
DROP COLUMNautomatically — no manual schema step.Deploy ordering
This must deploy only after the
on_failurecode is fully rolled out (#317). A pod stillrunning the previous code would query
halt_on_failure; dropping it before then would breakthat pod mid-deploy.