Skip to content

[codex] prepared approval actions#20

Merged
nahiyankhan merged 1 commit into
mainfrom
codex/prepared-approval-actions
Jun 10, 2026
Merged

[codex] prepared approval actions#20
nahiyankhan merged 1 commit into
mainfrom
codex/prepared-approval-actions

Conversation

@nahiyankhan

Copy link
Copy Markdown
Collaborator

Summary

Adds prepared approval actions so approval-gated capabilities approve a host-prepared frozen request instead of raw generated args.

  • Adds ApprovalPrepared and ApprovalRequest public types, optional approval.prepare(args), request ids in approval state, and ctx.approval for approved handlers.
  • Keeps existing one-argument approval.request(args) callbacks source-compatible.
  • Replaces demo window.confirm approval with small host-owned approval cards outside the sandbox.
  • Updates adoption/security docs with the invariant that hosts prepare, users approve, and handlers execute the frozen plan.
  • Adds unit and gallery e2e coverage for invalid args, prepared plans, request ids, approval, and denial.

Validation

  • pnpm typecheck
  • pnpm test
  • pnpm test:gallery

@nahiyankhan nahiyankhan marked this pull request as ready for review June 10, 2026 20:34
@nahiyankhan nahiyankhan merged commit 52e3b69 into main Jun 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant