fix: resolve $ref schemas for query and header param coercion#15
Merged
maxholman merged 1 commit intoblock65:masterfrom Apr 9, 2026
Merged
Conversation
When a query or header param schema is a $ref to a component schema (e.g., ExpireTime with type: "integer"), the ref was passed through unchanged to the valibot generator which emitted v.number() — failing on string values from HTTP. Now $ref schemas are resolved inline for query/header params so the string-to-number coercion pipeline applies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$ref(e.g.,$ref: "#/components/schemas/ExpireTime"withtype: "integer"), resolve it inline so the string-to-number coercion pipeline applies$refwas passed through unchanged, generatingv.number()which rejected string values from HTTP query stringsexpireTimeSchema) stays asv.number()(correct for non-HTTP contexts); only the query/header param schema gets coercionTest plan
expquery param now uses$reftoExpireTimecomponent schemav.string() → v.digits() → v.transform(parseInt) → v.number()🤖 Generated with Claude Code