Fix ComputeNudgeWindow startEpochNs computation to check full startDateDuration sign#723
Merged
Merged
Conversation
Manishearth
force-pushed
the
agent-driven/fix-computenudgewindow-sign
branch
from
6f78892 to
521e86b
Compare
Contributor
Author
…k full startDateDuration sign
Manishearth
force-pushed
the
agent-driven/fix-computenudgewindow-sign
branch
from
521e86b to
1974edb
Compare
nekevss
approved these changes
May 28, 2026
beckysiegel
pushed a commit
to chromium/chromium
that referenced
this pull request
May 28, 2026
This patch uplifts boa-dev/temporal#723 to fix ComputeNudgeWindow startEpochNs computation. Bug: None Change-Id: If97ae80becb194299b352e241c58531501b1d7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7879969 Commit-Queue: Julia Hansbrough <flowerhack@google.com> Reviewed-by: Julia Hansbrough <flowerhack@google.com> Auto-Submit: Manish Goregaokar <manishearth@google.com> Cr-Commit-Position: refs/heads/main@{#1637504}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
May 28, 2026
This patch uplifts boa-dev/temporal#723 to fix ComputeNudgeWindow startEpochNs computation. Bug: None Change-Id: If97ae80becb194299b352e241c58531501b1d7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7879969 Commit-Queue: Julia Hansbrough <flowerhack@google.com> Reviewed-by: Julia Hansbrough <flowerhack@google.com> Auto-Submit: Manish Goregaokar <manishearth@google.com> Cr-Commit-Position: refs/heads/main@{#1637504} NOKEYCHECK=True GitOrigin-RevId: 7e7bcc6c55f776283debaf33588e673020280a77
hubot
pushed a commit
to v8/v8
that referenced
this pull request
May 28, 2026
Fixed with boa-dev/temporal#723 Change-Id: Iff17aca66cf349ecdd10dd2e68a35a140f0d30b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7882206 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Manish Goregaokar <manishearth@google.com> Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#107647}
Hans-Halverson
added a commit
to Hans-Halverson/brimstone
that referenced
this pull request
Jun 26, 2026
## Summary Mark the implementation of the [Temporal proposal](https://github.com/tc39/proposal-temporal) complete, enabling all test262 tests and updating the README to advertise this. Only possible due to the [temporal_rs](https://github.com/boa-dev/temporal) crate, much thanks. The only remaining failing test262 Temporal tests were due to an [upstream bug](boa-dev/temporal#723) in the `temporal_rs` crate that has been fixed. Upgrade to version 0.2.4 which was just released and contains this fix. ## Tests - All test262 Temporal tests are now run by default and in CI. All pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tc39/proposal-temporal#3316
Test translated from test262 by Gemini.