Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates a wide range of dependencies and refactors the bootc-composefs logic to utilize the OciDigest type for image configuration digests. It also updates the codebase to accommodate a signature change in the composefs library's set_insecure method. Feedback is provided regarding a potential regression in upgrade_composefs where a change in the digest string format could cause comparisons to fail, thereby breaking the optimization for skipping redundant updates.
Note this also includes a repository format bump; this is known to break upgrades currently. Will aim to address that in the future. Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
bump-composefs-rs
branch
from
0bd563f to
7eacedc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest APIs and code. Note this rolls in a variety of changes, including a repository format bump.
Assisted-by: OpenCode (Claude Opus 4)