Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion bothub_cli/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,26 @@ def extract_dist_package(dist_file_path, target_dir=None):
_target_dir = target_dir or '.'

with tarfile.open(dist_file_path, 'r:gz') as tin:
tin.extractall(_target_dir)
def is_within_directory(directory, target):

abs_directory = os.path.abspath(directory)
abs_target = os.path.abspath(target)

prefix = os.path.commonprefix([abs_directory, abs_target])

return prefix == abs_directory

def safe_extract(tar, path=".", members=None, *, numeric_owner=False):

for member in tar.getmembers():
member_path = os.path.join(path, member.name)
if not is_within_directory(path, member_path):
raise Exception("Attempted Path Traversal in Tar File")

tar.extractall(path, members, numeric_owner=numeric_owner)


safe_extract(tin, _target_dir)


def make_event(message):
Expand Down