Skip to content

feat(opapi): Export state options#657

Merged
franklevasseur merged 14 commits into
masterfrom
xh/feat/opapi-export-state-options
Nov 7, 2025
Merged

feat(opapi): Export state options#657
franklevasseur merged 14 commits into
masterfrom
xh/feat/opapi-export-state-options

Conversation

@xavierhamel

@xavierhamel xavierhamel commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Contributes to SQD-3392

Adds an option to export... functions:

{
  ignoreDefaultParameters: true,
  ignoreSecurity: true,
}

By default defaultParameters and security will still be added to exported values.

@franklevasseur If we do it this way, we will have to break public-api to add defaultParameter. The part that will be broken by public-api is only used once in the code base (botpress/packages/clients/openapi.ts).

We could do it the other way around (breaking opapi, but not public-api by adding includeDefaultParameters instead), but that would be a way bigger refactor, because opapi is used everywhere.

See https://github.com/botpress/skynet/pull/3525

@linear

linear Bot commented Nov 6, 2025

Copy link
Copy Markdown

franklevasseur
franklevasseur previously approved these changes Nov 6, 2025

@franklevasseur franklevasseur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to post my review

Comment thread opapi/src/opapi.ts Outdated
Comment thread opapi/src/opapi.ts Outdated
Comment thread opapi/src/opapi.ts Outdated
@franklevasseur franklevasseur merged commit ae57a2b into master Nov 7, 2025
1 check passed
@franklevasseur franklevasseur deleted the xh/feat/opapi-export-state-options branch November 7, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants