feat(opapi): Export state options#657
Merged
Merged
Conversation
franklevasseur
previously approved these changes
Nov 6, 2025
franklevasseur
left a comment
Member
There was a problem hiding this comment.
forgot to post my review
franklevasseur
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to SQD-3392
Adds an option to
export...functions:By default
defaultParametersandsecuritywill still be added to exported values.@franklevasseur If we do it this way, we will have to break
public-apito adddefaultParameter. The part that will be broken bypublic-apiis only used once in the code base (botpress/packages/clients/openapi.ts).We could do it the other way around (breaking opapi, but not public-api by adding
includeDefaultParametersinstead), but that would be a way bigger refactor, because opapi is used everywhere.See https://github.com/botpress/skynet/pull/3525