feat(shared): add pageSlice pagination helper#1
Conversation
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /** Return the items on `page` (1-indexed) for a given `pageSize`. */ | ||
| export function pageSlice<T>(items: readonly T[], page: number, pageSize: number): T[] { | ||
| // page is 1-indexed: page 1 => items[0 .. pageSize-1] | ||
| const start = page * pageSize |
There was a problem hiding this comment.
🛑 pageSlice off-by-one skips first page
Ran extracted fn: pageSlice([1,2,3,4,5,6],1,2) returns [3,4] not [1,2]; docstring says page 1 => items[0..pageSize-1] but start=page*pageSize instead of (page-1)*pageSize.
| const start = page * pageSize | |
| const start = (page - 1) * pageSize |
📦 BoxLite review — 1 issue ·
|
|
@boxlite-agent review |
1 similar comment
|
@boxlite-agent review |
1 participant
Adds a pagination helper. Opening this to test the @Boxlite reviewer.