Skip to content

feat(): spatial indexing - #29

Closed
ShaMan123 wants to merge 16 commits into
bpmn-io:mainfrom
ShaMan123:feat/spatial-index
Closed

feat(): spatial indexing#29
ShaMan123 wants to merge 16 commits into
bpmn-io:mainfrom
ShaMan123:feat/spatial-index

Conversation

@ShaMan123

@ShaMan123 ShaMan123 commented Oct 17, 2025

Copy link
Copy Markdown

Proposed Changes

Closes #26

Rebase onto #27, diff

Introduces a spatial index interface that allows to query curve bbox and boost performance.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@ShaMan123
ShaMan123 force-pushed the feat/spatial-index branch 2 times, most recently from d7d9cf7 to 7df5bff Compare October 17, 2025 14:44

@ShaMan123 ShaMan123 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shows that after #26 it is trivial to use the repo with a spatial index so I am OK with not having it part of the repo as long as we export the essentials.
But if we provide a built in index that would be valuable.

@barmac

barmac commented Oct 27, 2025

Copy link
Copy Markdown
Member

There is a problem with types on CI, please check.

@ShaMan123
ShaMan123 force-pushed the feat/spatial-index branch 2 times, most recently from 59a777c to 620b301 Compare October 28, 2025 04:43
@nikku
nikku marked this pull request as draft November 24, 2025 07:55
@nikku

nikku commented Nov 24, 2025

Copy link
Copy Markdown
Member

@ShaMan123 I turned this into a draft, I believe it is not complete (yet).

@ShaMan123

Copy link
Copy Markdown
Author

What are you missing? An actual impl in tests?

@nikku

nikku commented Nov 24, 2025

Copy link
Copy Markdown
Member

@ShaMan123 I'm not sure what this PR is, is it a work in progress draft? Is it a proposal for a new API? The tests don't run and as a maintainer of this library I wonder if they should.

@nikku

nikku commented Nov 24, 2025

Copy link
Copy Markdown
Member

Please rebase this PR on top of #31 / main (released with v4.0.0). Please also consider if/why you'd need the following optimizations:

They did not make it into v4.0.0, but can be added as a follow-up.

@nikku

nikku commented Nov 24, 2025

Copy link
Copy Markdown
Member

#32 is open to pre-allocate dots*.

@nikku nikku closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convex hull spatial indexing

3 participants