Skip to content

DisableCAS support #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lovelock wants to merge 11 commits into from
Closed

DisableCAS support #113

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1af313e
DisableCAS support
Dec 20, 2019
a9efc0f
Merge branch 'bradfitz:master' into master
lovelock Feb 16, 2022
7982c31
provide roundrobin server selector for some non-standard memcache ser…
Feb 16, 2022
3f0e2e4
version v3
Feb 17, 2022
21e132d
version v3.0.2
Feb 17, 2022
51ed349
version upgrade
Feb 17, 2022
7f1081b
document more
Feb 17, 2022
7cb416e
fix typo in doc
Feb 17, 2022
bdca2e8
modify vulnerable statements according to SA4011
Feb 17, 2022
4dfff16
use write lock instead of read lock
Feb 25, 2022
1f8d01b
keep pace with upstream
Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions memcache/memcache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func New(server ...string) *Client {

// NewFromSelector returns a new Client using the provided ServerSelector.
func NewFromSelector(ss ServerSelector) *Client {
return &Client{selector: ss}
return &Client{selector: ss, DisableCAS: false}
}

// Client is a memcache client.
Expand All @@ -148,6 +148,10 @@ type Client struct {

lk sync.Mutex
freeconn map[string][]*conn

// When true, get is sent instead of gets when Client.Get() is called.
// Default false.
DisableCAS bool
}

// Item is an item to be got or stored in a memcached server.
Expand Down Expand Up @@ -362,8 +366,13 @@ func (c *Client) withKeyRw(key string, fn func(*bufio.ReadWriter) error) error {
}

func (c *Client) getFromAddr(addr net.Addr, keys []string, cb func(*Item)) error {
cmd := "gets"
if c.DisableCAS {
Copy link
Copy Markdown
Collaborator

@dormando dormando Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the meat of this PR is here... the DisableCAS bool that changes the command sent.

cmd = "get"
}

return c.withAddrRw(addr, func(rw *bufio.ReadWriter) error {
if _, err := fmt.Fprintf(rw, "gets %s\r\n", strings.Join(keys, " ")); err != nil {
if _, err := fmt.Fprintf(rw, "%s %s\r\n", cmd, strings.Join(keys, " ")); err != nil {
return err
}
if err := rw.Flush(); err != nil {
Expand Down