Repository navigation
Keep trace capture responsive during daemon recovery - #257
Merged
Merged
Conversation
Stephen Belanger (Qard)
marked this pull request as ready for review
November 3, 2026 10:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
November 3, 2026 10:00
Abhijeet Prasad (AbhiPrasad)
approved these changes
Nov 3, 2026
Stephen Belanger (Qard)
pushed a commit
to braintrustdata/bt
that referenced
this pull request
Nov 4, 2026
Updates coding-agent tracing to the latest plugin monorepo commit, bringing in all merged changes since the previous pin. Hook capture can finish while the daemon recovers earlier events, helping prevent hook timeouts in long sessions ([#257](braintrustdata/braintrust-coding-agent-plugins#257)). Also includes support for attaching managed runs to an existing trace, corrected Cursor subagent parenting, and OpenCode model variants. [Full upstream changes](braintrustdata/braintrust-coding-agent-plugins@aa8e99c...055eedf). Validated on the pinned Rust 1.97.1 toolchain: seven tracing-host tests, 24 tracing CLI tests, locked Cargo metadata, and diff checks passed. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trace hooks can time out while the daemon recovers a large backlog. Hooks now durably record and queue new events independently of recovery, so they can return without waiting for translation or delivery. Concurrent daemon starts preserve one socket owner.
Journal writing, stored formats, and Pi delta encoding remain unchanged from main. Recovery and translation run in the background, with bounded queues falling back to journal replay when full.
Related: SDK-722 and SDK-741.
Validation covers ordered output equivalence for every supported agent across journal replay, live input, overflow, mixed live/recovery gaps, and restart at every native event boundary. Real Codex, Claude, OpenCode, and Pi CLI tests pass against mock inference and ingest, including Pi nested tools and images. The original journal tests remain unchanged.
Review found and fixed extra payload retention before dispatch and a concurrent SQLite initialization race. The latter reproduced on local run 51; 150 consecutive runs pass after the fix. Recursive restart recovery also passes 100 consecutive runs. The Windows overflow test now explicitly waits for its unrouted translation actor. Local validation passes: 388 library tests, 291 integration tests, all five optional Codex/Claude/OpenCode/Pi tests, formatting, and Clippy. All 23 CI checks pass on 517c083, including daemon tests on Linux, macOS, and Windows. Other agent integrations have fixture coverage locally; their real CLIs were not executed.