Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/plugins/pi/content/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,15 @@
},
"devDependencies": {
"@earendil-works/pi-coding-agent": "^1.0.0",
"@earendil-works/pi-tui": "^1.0.0",
"@types/node": "^26.6.4",
"typescript": "^6.0.3",
"vite-plus": "^1.4.0",
"vitest": "5.0.5"
},
"peerDependencies": {
"@earendil-works/pi-coding-agent": "*"
"@earendil-works/pi-coding-agent": "*",
"@earendil-works/pi-tui": "*"
},
"packageManager": "pnpm@11.21.0",
"pi": {
Expand Down
15 changes: 9 additions & 6 deletions src/plugins/pi/content/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 44 additions & 18 deletions src/plugins/pi/content/src/daemon-adapter.test.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { hyperlink } from "@earendil-works/pi-tui";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";

const mockState = vi.hoisted(() => ({
logs: [] as Array<Record<string, unknown>>,
flushes: [] as string[],
closed: 0,
claim: true,
hyperlinks: true,
legacyContinuation: undefined as Record<string, unknown> | undefined,
legacyContinuationFor: vi.fn(),
logGate: undefined as Promise<void> | undefined,
Expand All @@ -13,6 +15,11 @@ const mockState = vi.hoisted(() => ({
permalink: "https://www.braintrust.dev/trace/1" as string | undefined,
}));

vi.mock("@earendil-works/pi-tui", async (importOriginal) => ({
...(await importOriginal<typeof import("@earendil-works/pi-tui")>()),
getCapabilities: () => ({ hyperlinks: mockState.hyperlinks }),
}));

vi.mock("./runtime/daemon-client.ts", () => ({
claimManagedTracingInstance: () => mockState.claim,
DaemonClient: class {
Expand Down Expand Up @@ -113,6 +120,7 @@ describe("Pi daemon adapter", () => {
mockState.flushes.length = 0;
mockState.closed = 0;
mockState.claim = true;
mockState.hyperlinks = true;
mockState.legacyContinuation = undefined;
mockState.legacyContinuationFor.mockClear();
mockState.logGate = undefined;
Expand Down Expand Up @@ -173,14 +181,14 @@ describe("Pi daemon adapter", () => {
await handlers.get("session_shutdown")?.({ reason: "quit" }, ctx);

expect(statuses.at(-1)).toEqual(["braintrust-tracing", undefined]);
expect(widgets.at(-1)).toEqual(["braintrust-trace-link", undefined]);
expect(widgets).toEqual([]);

releaseStatus();
await Promise.resolve();
await Promise.resolve();

expect(statuses).toEqual([["braintrust-tracing", undefined]]);
expect(widgets).toEqual([["braintrust-trace-link", undefined]]);
expect(widgets).toEqual([]);
});

it("forwards native events and keeps the trace-link UI", async () => {
Expand Down Expand Up @@ -286,22 +294,45 @@ describe("Pi daemon adapter", () => {
),
).toEqual(["text_delta", "thinking_delta"]);
expect(mockState.flushes).toHaveLength(0);
expect(widgets).toContainEqual([
"braintrust-trace-link",
["Braintrust trace", "https://www.braintrust.dev/trace/1"],
{ placement: "belowEditor" },
expect(statuses).toContainEqual([
"braintrust-tracing",
hyperlink("Braintrust trace ↗", "https://www.braintrust.dev/trace/1"),
]);
expect(widgets).toEqual([]);
expect(statuses.length).toBeGreaterThan(0);
expect(mockState.closed).toBe(2);
});

it.each([true, false])(
"respects hyperlink capability %s without displaying the URL",
async (supported) => {
mockState.hyperlinks = supported;
const setStatus = vi.fn();
const setWidget = vi.fn();
const ctx = fakeContext({ setStatus, setWidget });
const handlers = await loadExtension();
await handlers.get("session_start")?.({ reason: "new" }, ctx);
const expectedLabel = supported
? hyperlink("Braintrust trace ↗", mockState.permalink!)
: "Braintrust: connected";
await vi.waitFor(() =>
expect(setStatus).toHaveBeenCalledWith("braintrust-tracing", expectedLabel),
);
expect(setWidget).not.toHaveBeenCalled();
if (!supported) {
expect(setStatus.mock.calls.flat().join(" ")).not.toContain("https://");
}
await handlers.get("session_shutdown")?.({ reason: "quit" }, ctx);
},
);

it("polls for the trace link until the daemon delivers the first turn", async () => {
vi.useFakeTimers();
try {
const widgets: unknown[] = [];
const statuses: unknown[] = [];
const ctx = fakeContext({
setStatus: vi.fn(),
setWidget: (...args: unknown[]) => widgets.push(args),
setStatus: (...args: unknown[]) => statuses.push(args),
setWidget: vi.fn(),
});
const handlers = await loadExtension();

Expand All @@ -310,18 +341,13 @@ describe("Pi daemon adapter", () => {
await handlers.get("session_start")?.({ reason: "new" }, ctx);
await handlers.get("agent_end")?.({ messages: [] }, ctx);
await vi.advanceTimersByTimeAsync(10_000);
expect(widgets.at(-1)).toEqual([
"braintrust-trace-link",
undefined,
{ placement: "belowEditor" },
]);
expect(statuses.at(-1)).toEqual(["braintrust-tracing", "Braintrust: connected"]);

mockState.permalink = "https://www.braintrust.dev/trace/1";
await vi.advanceTimersByTimeAsync(2_000);
expect(widgets.at(-1)).toEqual([
"braintrust-trace-link",
["Braintrust trace", "https://www.braintrust.dev/trace/1"],
{ placement: "belowEditor" },
expect(statuses.at(-1)).toEqual([
"braintrust-tracing",
hyperlink("Braintrust trace ↗", "https://www.braintrust.dev/trace/1"),
]);

// Once the link is shown, neither the timer nor later turns query again.
Expand Down
16 changes: 9 additions & 7 deletions src/plugins/pi/content/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { createHash, randomUUID } from "node:crypto";
import { resolve } from "node:path";
import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
import { getCapabilities, hyperlink } from "@earendil-works/pi-tui";
import { loadConfig } from "./config.ts";
import { legacyContinuationFor, type LegacyContinuation } from "./legacy-session.ts";
import { runningPiPackage } from "./pi-package.ts";
import { claimManagedTracingInstance, DaemonClient } from "./runtime/daemon-client.ts";
import { EXTENSION_VERSION } from "./version.ts";

const STATUS_KEY = "braintrust-tracing";
const WIDGET_KEY = "braintrust-trace-link";
const UI_STATUS_TIMEOUT_MS = 250;
// The daemon uploads a turn after Pi reports agent_end: about a second later
// with flush_on_turn_end, and when its 30 s batch window closes with
Expand Down Expand Up @@ -133,15 +133,18 @@ export default function braintrustPiExtension(pi: ExtensionAPI): void {
const daemonSession = status?.sessions.find(
(session) => session.session_id === refreshSessionId,
);
const permalink = config.showTraceLink ? daemonSession?.permalink : undefined;
const traceLabel = "Braintrust trace ↗";
if (daemonSession?.last_error) {
ctx.ui.setStatus(STATUS_KEY, `Braintrust: ${daemonSession.last_error}`);
} else {
ctx.ui.setStatus(STATUS_KEY, "Braintrust: tracing");
ctx.ui.setStatus(
STATUS_KEY,
permalink && getCapabilities().hyperlinks
? hyperlink(traceLabel, permalink)
: "Braintrust: connected",
);
}
const permalink = config.showTraceLink ? daemonSession?.permalink : undefined;
ctx.ui.setWidget(WIDGET_KEY, permalink ? ["Braintrust trace", permalink] : undefined, {
placement: "belowEditor",
});
traceLinkShown = Boolean(permalink);
};

Expand Down Expand Up @@ -285,7 +288,6 @@ export default function braintrustPiExtension(pi: ExtensionAPI): void {
lastContext = undefined;
if (ctx.hasUI) {
ctx.ui.setStatus(STATUS_KEY, undefined);
ctx.ui.setWidget(WIDGET_KEY, undefined);
}
await client.close();
await statusClient.close();
Expand Down
Loading