Skip to content

Ark/bra 3203 otel attachments #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Kent (realark) merged 2 commits into from
Oct 21, 2025
Merged

Ark/bra 3203 otel attachments #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
371974d
test image fixture
realark Oct 15, 2025
4a38281
Braintrust-friendly attachments, conforming to otel genai semconv
realark Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
255 changes: 12 additions & 243 deletions src/main/java/dev/braintrust/instrumentation/openai/otel/ChatCompletionEventsHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import static io.opentelemetry.api.common.AttributeKey.stringKey;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.openai.models.chat.completions.ChatCompletion;
import com.openai.models.chat.completions.ChatCompletionAssistantMessageParam;
import com.openai.models.chat.completions.ChatCompletionContentPartText;
Expand All @@ -24,36 +23,28 @@
import io.opentelemetry.api.logs.Logger;
import io.opentelemetry.api.trace.Span;
import io.opentelemetry.context.Context;
import java.lang.invoke.MethodHandle;
import java.lang.invoke.MethodHandles;
import java.lang.invoke.MethodType;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.stream.Collectors;
import javax.annotation.Nullable;
import lombok.SneakyThrows;
import lombok.extern.slf4j.Slf4j;

@Slf4j
final class ChatCompletionEventsHelper {

private static final AttributeKey<String> EVENT_NAME = stringKey("event.name");
private static final ObjectMapper JSON_MAPPER =
new com.fasterxml.jackson.databind.ObjectMapper();

@SneakyThrows
public static void emitPromptLogEvents(
Context context,
Logger eventLogger,
ChatCompletionCreateParams request,
boolean captureMessageContent) {
Span.current()
.setAttribute(
"braintrust.input_json",
JSON_MAPPER.writeValueAsString(request.messages()));
String semconvJson = GenAiSemconvSerializer.serializeInputMessages(request.messages());
Span span = Span.current();
span.setAttribute("gen_ai.input.messages", semconvJson);
}

private static String contentToString(ChatCompletionToolMessageParam.Content content) {
Expand Down Expand Up @@ -138,13 +129,12 @@ public static void emitCompletionLogEvents(
} else if (completion.choices().size() > 1) {
log.debug("multiple choices in OAI response: {}", completion.choices().size());
} else {
Span.current()
.setAttribute(
"braintrust.output_json",
JSON_MAPPER.writeValueAsString(
new ChatCompletionMessage[] {
completion.choices().get(0).message()
}));
// Set gen_ai.output.messages attribute for single choice (most common case)
ChatCompletion.Choice choice = completion.choices().get(0);
String outputJson =
GenAiSemconvSerializer.serializeOutputMessage(
choice.message(), choice.finishReason().toString());
Span.current().setAttribute("gen_ai.output.messages", outputJson);
}
for (ChatCompletion.Choice choice : completion.choices()) {
ChatCompletionMessage choiceMsg = choice.message();
Expand Down Expand Up @@ -211,7 +201,8 @@ private static LogRecordBuilder newEvent(Logger eventLogger, String name) {
private static Value<?> buildToolCallEventObject(
ChatCompletionMessageToolCall call, boolean captureMessageContent) {
Map<String, Value<?>> result = new HashMap<>();
FunctionAccess functionAccess = getFunctionAccess(call);
GenAiSemconvSerializer.FunctionAccess functionAccess =
GenAiSemconvSerializer.getFunctionAccess(call);
if (functionAccess != null) {
result.put("id", Value.of(functionAccess.id()));
result.put(
Expand All @@ -223,7 +214,7 @@ private static Value<?> buildToolCallEventObject(
}

private static Value<?> buildFunctionEventObject(
FunctionAccess functionAccess, boolean captureMessageContent) {
GenAiSemconvSerializer.FunctionAccess functionAccess, boolean captureMessageContent) {
Map<String, Value<?>> result = new HashMap<>();
result.put("name", Value.of(functionAccess.name()));
if (captureMessageContent) {
Expand All @@ -232,227 +223,5 @@ private static Value<?> buildFunctionEventObject(
return Value.of(result);
}

@Nullable
private static FunctionAccess getFunctionAccess(ChatCompletionMessageToolCall call) {
if (V1FunctionAccess.isAvailable()) {
return V1FunctionAccess.create(call);
}
if (V3FunctionAccess.isAvailable()) {
return V3FunctionAccess.create(call);
}

return null;
}

private interface FunctionAccess {
String id();

String name();

String arguments();
}

private static String invokeStringHandle(@Nullable MethodHandle methodHandle, Object object) {
if (methodHandle == null) {
return "";
}

try {
return (String) methodHandle.invoke(object);
} catch (Throwable ignore) {
return "";
}
}

private static class V1FunctionAccess implements FunctionAccess {
@Nullable private static final MethodHandle idHandle;
@Nullable private static final MethodHandle functionHandle;
@Nullable private static final MethodHandle nameHandle;
@Nullable private static final MethodHandle argumentsHandle;

static {
MethodHandle id;
MethodHandle function;
MethodHandle name;
MethodHandle arguments;

try {
MethodHandles.Lookup lookup = MethodHandles.lookup();
id =
lookup.findVirtual(
ChatCompletionMessageToolCall.class,
"id",
MethodType.methodType(String.class));
Class<?> functionClass =
Class.forName(
"com.openai.models.chat.completions.ChatCompletionMessageToolCall$Function");
function =
lookup.findVirtual(
ChatCompletionMessageToolCall.class,
"function",
MethodType.methodType(functionClass));
name =
lookup.findVirtual(
functionClass, "name", MethodType.methodType(String.class));
arguments =
lookup.findVirtual(
functionClass, "arguments", MethodType.methodType(String.class));
} catch (Exception exception) {
id = null;
function = null;
name = null;
arguments = null;
}
idHandle = id;
functionHandle = function;
nameHandle = name;
argumentsHandle = arguments;
}

private final ChatCompletionMessageToolCall toolCall;
private final Object function;

V1FunctionAccess(ChatCompletionMessageToolCall toolCall, Object function) {
this.toolCall = toolCall;
this.function = function;
}

@Nullable
static FunctionAccess create(ChatCompletionMessageToolCall toolCall) {
if (functionHandle == null) {
return null;
}

try {
return new V1FunctionAccess(toolCall, functionHandle.invoke(toolCall));
} catch (Throwable ignore) {
return null;
}
}

static boolean isAvailable() {
return idHandle != null;
}

@Override
public String id() {
return invokeStringHandle(idHandle, toolCall);
}

@Override
public String name() {
return invokeStringHandle(nameHandle, function);
}

@Override
public String arguments() {
return invokeStringHandle(argumentsHandle, function);
}
}

static class V3FunctionAccess implements FunctionAccess {
@Nullable private static final MethodHandle functionToolCallHandle;
@Nullable private static final MethodHandle idHandle;
@Nullable private static final MethodHandle functionHandle;
@Nullable private static final MethodHandle nameHandle;
@Nullable private static final MethodHandle argumentsHandle;

static {
MethodHandle functionToolCall;
MethodHandle id;
MethodHandle function;
MethodHandle name;
MethodHandle arguments;

try {
MethodHandles.Lookup lookup = MethodHandles.lookup();
functionToolCall =
lookup.findVirtual(
ChatCompletionMessageToolCall.class,
"function",
MethodType.methodType(Optional.class));
Class<?> functionToolCallClass =
Class.forName(
"com.openai.models.chat.completions.ChatCompletionMessageFunctionToolCall");
id =
lookup.findVirtual(
functionToolCallClass, "id", MethodType.methodType(String.class));
Class<?> functionClass =
Class.forName(
"com.openai.models.chat.completions.ChatCompletionMessageFunctionToolCall$Function");
function =
lookup.findVirtual(
functionToolCallClass,
"function",
MethodType.methodType(functionClass));
name =
lookup.findVirtual(
functionClass, "name", MethodType.methodType(String.class));
arguments =
lookup.findVirtual(
functionClass, "arguments", MethodType.methodType(String.class));
} catch (Exception exception) {
functionToolCall = null;
id = null;
function = null;
name = null;
arguments = null;
}
functionToolCallHandle = functionToolCall;
idHandle = id;
functionHandle = function;
nameHandle = name;
argumentsHandle = arguments;
}

private final Object functionToolCall;
private final Object function;

V3FunctionAccess(Object functionToolCall, Object function) {
this.functionToolCall = functionToolCall;
this.function = function;
}

@Nullable
@SuppressWarnings("unchecked")
static FunctionAccess create(ChatCompletionMessageToolCall toolCall) {
if (functionToolCallHandle == null || functionHandle == null) {
return null;
}

try {
Optional<Object> optional =
(Optional<Object>) functionToolCallHandle.invoke(toolCall);
if (!optional.isPresent()) {
return null;
}
Object functionToolCall = optional.get();
return new V3FunctionAccess(
functionToolCall, functionHandle.invoke(functionToolCall));
} catch (Throwable ignore) {
return null;
}
}

static boolean isAvailable() {
return idHandle != null;
}

@Override
public String id() {
return invokeStringHandle(idHandle, functionToolCall);
}

@Override
public String name() {
return invokeStringHandle(nameHandle, function);
}

@Override
public String arguments() {
return invokeStringHandle(argumentsHandle, function);
}
}

private ChatCompletionEventsHelper() {}
}
Loading