Repository navigation
fix(mcp): make telemetry optional for tool calls - #459
Merged
Merged
Conversation
> 🤖 **This text was AI-generated.**
MCP tool schemas can mark telemetry as required even though the server
accepts calls without it. This caused bt to reject otherwise valid input:
```json
{"query": "synthetic query"}
```
Treat top-level telemetry as optional in argument validation and help.
Send omitted telemetry as omitted, and preserve supplied values such as:
```json
{"query": "synthetic query", "telemetry": {}}
```
Keep other required fields and type checks. No intent is fabricated, and
no server change or version gate is needed.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Stephen Belanger (Qard)
approved these changes
Oct 30, 2026
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
always adding telemetry is a bunch of friction for the
bt mcpcalls.MCP tool schemas can mark telemetry as required even though the server accepts calls without it. This caused bt to reject otherwise valid input:
{"query": "synthetic query"}Treat top-level telemetry as optional in argument validation and help. Send omitted telemetry as omitted, and preserve supplied values such as:
{"query": "synthetic query", "telemetry": {}}Keep other required fields and type checks. No intent is fabricated, and no server change or version gate is needed.
Co-authored by StarfolkAI (@starfolkai)[bot]