Skip to content

Fix opus regex #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erin McNulty (erin2722) merged 1 commit into from
May 28, 2026
Merged

Fix opus regex #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/lingua/src/providers/anthropic/adapter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1852,6 +1852,7 @@ mod tests {
let adapter = AnthropicAdapter;

for model in [
"claude-opus-4-20250514",
Copy link
Copy Markdown
Contributor Author

@erin2722 Erin McNulty (erin2722) May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this was a valid model name 😢 fixed

"claude-opus-4-6",
"claude-opus-4-5-20250514",
"claude-sonnet-4-5-20250929",
Expand Down
11 changes: 9 additions & 2 deletions crates/lingua/src/providers/anthropic/capabilities.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ use std::sync::LazyLock;

const OUTPUT_CONFIG_EFFORT_MODEL_PREFIXES: &[&str] = &["claude-opus-4-5", "claude-opus-4-6"];
static OPUS_4_7_OR_LATER_RE: LazyLock<Regex> = LazyLock::new(|| {
Regex::new(r"(^|[./:@])claude-opus-(4[-.]([7-9]|\d{2,})|([5-9]|\d{2,})[-.]\d+)($|[-./:@])")
.expect("valid Opus 4.7+ model regex")
Regex::new(
r"(^|[./:@])claude-opus-(4[-.]([7-9]|[1-9]\d)|([5-9]|[1-9]\d)[-.]\d{1,2})($|[-./:@])",
)
.expect("valid Opus 4.7+ model regex")
});

/// Check if a model supports `output_config.effort` (vs legacy `thinking`).
Expand Down Expand Up @@ -133,6 +135,7 @@ mod tests {

// Other models do not
assert!(!supports_output_config_effort("claude-opus-4-4"));
assert!(!supports_output_config_effort("claude-opus-4-20250514"));
assert!(!supports_output_config_effort(
"us.anthropic.claude-sonnet-4-5-20250929-v1:0"
));
Expand Down Expand Up @@ -161,6 +164,7 @@ mod tests {
"anthropic/claude-opus-5-0@20260701",
];
let legacy_models = [
"claude-opus-4-20250514",
"claude-opus-4-6",
"claude-opus-4-5-20250514",
"claude-sonnet-4-5-20250929",
Expand Down Expand Up @@ -208,6 +212,7 @@ mod tests {
&[StripSamplingParams][..],
),
("claude-opus-4-6", &[][..]),
("claude-opus-4-20250514", &[][..]),
("claude-opus-4-5-20250514", &[][..]),
("claude-sonnet-4-5-20250929", &[][..]),
("claude-3-5-sonnet-20241022", &[][..]),
Expand All @@ -231,6 +236,7 @@ mod tests {
"claude-opus-5-1-20260701",
];
let no_needs = [
"claude-opus-4-20250514",
"claude-opus-4-6",
"claude-opus-4-5",
"claude-sonnet-4-5-20250929",
Expand Down Expand Up @@ -262,6 +268,7 @@ mod tests {
"anthropic/claude-opus-5-0@20260701",
];
let preserve_models = [
"claude-opus-4-20250514",
"claude-opus-4-6",
"claude-opus-4-5-20250514",
"claude-sonnet-4-5-20250929",
Expand Down
Loading