Fix Google integer tool schema#261
Conversation
Ken Jiang (knjiang)
changed the title
Ken Jiang (knjiang)
requested review from
Alex Z (CLowbrow) and
Erin McNulty (erin2722)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae83909aad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| fn deserialize_optional_i64_string<'de, D>(deserializer: D) -> Result<Option<String>, D::Error> | ||
| where | ||
| D: serde::Deserializer<'de>, | ||
| { |
There was a problem hiding this comment.
This generated helper does not match the helper added to crates/generate-types/src/main.rs (the generator emits an untagged enum implementation, while this file contains a hand-written visitor with extra behavior such as visit_f64). Because generated.rs is regenerated from the generator, the next Google type regeneration will overwrite this implementation and make the committed output non-reproducible; please regenerate the file from the updated generator so the checked-in generated code exactly reflects the source-of-truth pipeline.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
let me regenrate before merging
Ken Jiang (knjiang)
force-pushed
the
05-29-fix_google_integer_tool_calls
branch
from
ae83909 to
c4d90a2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4d90a29b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
3 participants
Fix Google-native request detection for tool schemas whose typed
parametersinclude numeric JSON-Schema bounds such asminLength: 1. Google’s typedSchemadocuments int64 validation fields as protobuf-JSON strings, but JSON Schema emitters and tool generators commonly produce numeric values.without change:
