feat: harden GitHub Action execution#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install-mode: sourceso the action can build the checked-out repo for PR/self-test workflowsaction-smokeCI job plus a local smoke test that proves paths and output files with spaces work end to endWhy
The old action built a single shell string (
agentwise $ARGS), which breaks on paths with spaces and is a bad pattern in a security-focused repo. This change makes the action safer, reproducible, and self-testable before release.Validation
cargo fmt --all -- --checkβ PASScargo clippy --all-targets -- -D warningsβ PASScargo test --all-targetsβ PASS (217unit +38integration)cargo build --releaseβ PASSbash tests/action_smoke.shβ PASSbash -n scripts/action-install.sh scripts/action-scan.sh tests/action_smoke.shβ PASSnode /Users/bwise/.openclaw/workspace/projects/humanizer/src/cli.js score README.mdβ PASS (36/100)