feat(install_cloud_clis): lazy-load and cache bash completions#60
Merged
Conversation
Replace eager `source <(cmd completion bash)` calls with a `_lazy_completion` function that defers completion generation to first tab-complete, caches output under ~/.cache/bash_completions/, and auto-invalidates when the CLI binary is updated. This eliminates subprocess spawns at shell startup for ~8 CLIs. AWS CLI is unchanged — it already uses a direct binary completer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source <(cmd completion bash)calls at shell startup with a_lazy_completionfunction that defers completion generation to first tab-complete~/.cache/bash_completions/with automatic invalidation when the CLI binary is updatedcomplete -C)Test plan
~/.bashrccontains the_lazy_completionfunction and one-liner registrationsoc <tab>) and verify completions load and a cache file appears under~/.cache/bash_completions/blockinfilereports no changes (idempotency)install_cloud_clis_components: [aws]only and confirm the_lazy_completionfunction is not emitted🤖 Generated with Claude Code