Repository navigation
fix(start): guide coded duplicate workspace failures - #517
Merged
patelspratik merged 1 commit intoOct 21, 2026
Merged
patelspratik merged 1 commit into
patelspratik merged 1 commit into
Conversation
jarrad
marked this pull request as ready for review
October 21, 2026 15:23
patelspratik
approved these changes
Oct 21, 2026
Contributor
|
what's the consequence for older vesrions? they just get the wrong error message? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brev startduplicate remediation when workspace creation returns HTTP 400 and Brev codeWORKSPACE_ALREADY_EXISTS.The old
pkg/cmd/createimplementation is explicitly deprecated and is not registered asbrev create; the registered command ispkg/cmd/gpucreate, whose retry handling belongs to BREV-13207.Proof
go test ./pkg/cmd/start -count=1passed.go test ./pkg/store -run '^(TestHTTPResponseError|TestIsHTTPErrorCode)' -count=1passed.go vet ./pkg/store ./pkg/cmd/startpassed.go test ./pkg/storehas two existing WSL-specific tests that fail on macOS (TestBasicStore_GetWindowsDir,TestFileStore_GetWSLHostUserSSHConfigPath).The stacked PR targets a branch, while the repo's automatic PR workflows filter for
main. I dispatched the non-deployment validation workflows on this exact head (9ccc9928c8f4e61eab698e27f8091681f8b2f263): test, lint, build, vet, fmt, and CLI output compatibility. All passed. GitHub does not show these manually dispatched runs in the PR check rollup.Stack and rollout
Base: CLI parser foundation #515 (
fix/brev-13209-cli-error-codes), which starts from freshly fetched brev-cliorigin/main(a51d348a). This PR contains only start guidance changes in its review diff. BREV-13202 produces theWORKSPACE_ALREADY_EXISTSserver code; deploy that server contract before expecting the coded guidance in released CLI builds. BREV-13207 separately updates the livebrev createGPU retry path and should consume #515.