Conversation
The my_requests and my_approvals approval methods lacked a `headers` argument, so callers could not pass custom headers (e.g. X-On-Behalf-Of) the way my_access/my_resources already allow -- breaking on-behalf-of through the approval flow. Add the optional `headers` argument across my_requests.* and my_approvals.*. Also fix my_requests.list / my_approvals.list to request the approvals collection with a trailing slash (/v1/approvals/); without it the request 302-redirected and was rejected at the edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes:
headersargument tomy_requests.[list|approval_request_status|request_approval|request_approval_by_name|withdraw_approval_request|withdraw_approval_request_by_name]andmy_approvals.[list|approve_request|reject_request], so custom headers (e.g.X-On-Behalf-Of) propagate through the approval flow as they already do formy_access/my_resources.my_requests.listandmy_approvals.listto request the approvals collection with a trailing slash (/v1/approvals/); without it the request 302-redirected and was rejected at the edge.