This repository was archived by the owner on Jun 7, 2018. It is now read-only.
Notify when the queue changes#4
Open
jaisonerick wants to merge 1 commit into
Open
Conversation
Owner
|
@jaisonerick I agree with you about using events to communicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to integrate other plugins, I believe the simplest solution would be to trigger a lita event when the queue changes. That's what I did here: Any time someone is "next" on the queue, the
queue_changeevent is triggered with the room, the user name and the queue.I changed one detail in the current behavior. When the user queues himself, and he is, now, the only one there, besides from receive the "you've been added to queue" message, he also receives the "You are next, go ahead!".