Skip to content

Add support for aria-label username fields#399

Merged
max-baz merged 1 commit into
browserpass:masterfrom
radian-software:rr-aria-label
May 20, 2026
Merged

Add support for aria-label username fields#399
max-baz merged 1 commit into
browserpass:masterfrom
radian-software:rr-aria-label

Conversation

@raxod502
Copy link
Copy Markdown
Contributor

@raxod502 raxod502 commented Feb 7, 2026

Here's an example of a login page that this PR adds support for: https://portal.hmc.edu
(No account needed to view the login page, just click Login in the top right.)

Here is the input field for the username, which doesn't match any of the existing patterns:

<input id="identification" placeholder="Username" aria-label="Username" class="input placeholder-input ember-view ember-text-field">

However, aria-label="Username" seems pretty unambiguous to me, so I think we might as well match on it.

@max-baz max-baz merged commit 0138231 into browserpass:master May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants