SDK-6821 Phase 3: read apis from the binary's sessionData bucket (flat fallback) - #89
SDK-6821 Phase 3: read apis from the binary's sessionData bucket (flat fallback)#89anish353 wants to merge 12 commits into
Conversation
…821 Phase 3) The binary is relocating internal fields off session.config into a namespaced sessionData bucket in the StartBinSession/ConnectBinSession echo. Prefer config.sessionData.apis at the single parse site (setConfig serves both RPC paths), falling back to the flat config.apis so the service works against both old and new binaries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
remove this file from .changeset
|
🔴 SDK PR Review gate is red. Pending:
It turns green once the latest SDK PR Review Agent run reports GTG on the current head commit. A native reviewer approval is separately required by branch protection before merge. |
|
RUN_TESTS |
|
🔴 SDK PR Review gate is red. Pending:
It turns green once the latest SDK PR Review Agent run reports GTG on the current head commit. A native reviewer approval is separately required by branch protection before merge. |
Bucket-only (the Phase-4 shape the flat fallback cannot mask), bucket-beats-stale-flat, and flat-only (old binary) against the real setConfig. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🔴 SDK PR Review gate is red. Pending:
It turns green once the latest SDK PR Review Agent run reports GTG on the current head commit. A native reviewer approval is separately required by branch protection before merge. |
|
Re the review's test-coverage suggestion (the inline thread isn't reachable via API from my side, so replying at PR level): committed in 6c90d8c — a |
2 participants
What is this about?
Companion to browserstack-binary#1566 (SDK-6821): the binary relocates internal fields (
apis,capabilityMap,grr_region) offsession.configontosession.internal, and echoes them under a namespacedsessionDatabucket in the StartBinSession/ConnectBinSession config (flat fields retained for backward compat until every SDK migrates).This PR migrates the WDIO service's read: at the single config parse site (
setConfig, which serves BOTH the StartBinSession and ConnectBinSession paths vialoadModules), preferconfig.sessionData.apisand fall back to the flatconfig.apis. All downstream consumers (APIUtils.updateURLSForGRR→ automate/appAutomate/percy/observability/EDS/app-a11y service URLs) are untouched.Backward/forward compatible — works against old binaries (no bucket → flat fallback) and new ones (bucket preferred), so it's independently mergeable. Sibling PRs: node-agent#2335, python-sdk#1162, javaagent#2095, csharp-sdk#1196, ruby-sdk#176.
Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
apisservice-URL map from the binary's newconfig.sessionDatabucket (SDK-6821 session.config split), with the flatconfig.apisas backward-compat fallback. Single-point change insetConfig; verifiednpm run buildclean and the vitest suite shows zero new failures vs main (68 pre-existing environmental failures identical on both).Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.
🤖 Generated with Claude Code