Fix Duration doc examples to use message literal syntax#501
Merged
Conversation
The const, lt, lte, in, and not_in examples in DurationRules showed string values like "5s", which do not compile for google.protobuf.Duration option fields. Replace them with message literal syntax matching the gt, gte, and example docs. Fixes #499
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
pkwarren
approved these changes
Jul 9, 2026
timostamm
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
const,lt,lte,in, andnot_inexamples inDurationRulesshowed string values like5s, which do not compile forgoogle.protobuf.Duration-valued option fields. Replace them with message literal syntax matching the other correct example docs.Fixes #499