Skip to content

Add 256 Bytes per tag and 512 KB tags size limits. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andrei-Dolgolev wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add 256 Bytes per tag and 512 KB tags size limits. #37

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
571e33e
Add 1024 tag limit.
Apr 4, 2022
99492b5
Add 256 limit tag lenght and 512 KB tags per entry.
Apr 5, 2022
a8be8e5
Add settings variable.
Apr 5, 2022
37019c2
Fix mypy.
Apr 5, 2022
cb896b3
Add fixes.
Apr 5, 2022
1260557
Fix err message.
Apr 5, 2022
f79d78b
Remove comments.
Apr 5, 2022
c69bfa7
Add using env variable wich same on drones.
Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions spire/humbug/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,7 @@ def generate_humbug_dependencies(


async def remove_humbug_dependencies(
db_session: Session,
token: UUID,
humbug_event: HumbugEvent,
db_session: Session, token: UUID, humbug_event: HumbugEvent,
) -> None:
"""
Delete autogenerated user and remove it from journal holders.
Expand Down Expand Up @@ -355,9 +353,7 @@ async def create_humbug_user(
Create bugout autogenerated user for Humbug integration.
"""
new_humbug_user = HumbugBugoutUser(
user_id=user_id,
access_token_id=access_token_id,
event_id=event_id,
user_id=user_id, access_token_id=access_token_id, event_id=event_id,
)
db_session.add(new_humbug_user)
db_session.commit()
Expand Down Expand Up @@ -478,7 +474,7 @@ async def push_pack_to_journals_api(
JournalEntryContent(
title=report.title,
content=report.content,
tags=report.tags,
tags=[tag for tag in report.tags if tag and len(tag) <= 1024],
Copy link
Copy Markdown
Collaborator

@kompotkot kompotkot Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It not save, it checks only length of each tag, but I can still push 1,000,000 tags

context_id=str(restricted_token),
context_type="humbug",
created_at=report.created_at,
Expand Down