A-1050 and A-1060: Make checkout retry attempt configurable, increasing default retry#3822
Merged
A-1050 and A-1060: Make checkout retry attempt configurable, increasing default retry#3822
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c354802c97
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
swebb
reviewed
Apr 14, 2026
swebb
approved these changes
Apr 14, 2026
Contributor
swebb
left a comment
swebb
left a comment
There was a problem hiding this comment.
LGTM 👍
Low risk. 90% of this PR is simply argument handling. I had one question but I don't think it's a blocker.
zhming0
force-pushed
the
ming/a-1050-and-a-1060
branch
from
c354802 to
8c4d79b
Compare
This was referenced Apr 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Git checkout operation sometimes are subject to the mercy of network stability, a DNS blip can last for 30s+. Our current retry strategy is static and try 3 times, once every 2s. This may not capture some transient network failure scenarios and can be frustrating.
Git checkout errors, apart from initial pipeline setup, can arguably all be categorized as transient errors. So I reckon we should do two things:
Context
A-1050 and A-1060
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Me and a LLM donkey