Skip to content

Skip redundant lint steps via hk ci profile #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rblaine95 merged 1 commit into from
Jun 27, 2026
Merged

Skip redundant lint steps via hk ci profile #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@ jobs:

- run: cargo clippy --all-targets --all-features --workspace
- run: cargo fmt --check --all
- run: hk check --all --skip-step no_commit_protected_branch
- run: hk check --all --profile ci
env:
GITHUB_TOKEN: ${{ github.token }}
15 changes: 12 additions & 3 deletions hk.pkl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@ local linters = new Mapping<String, Step> {
// Lint Github Actions
["action_lint"] = Builtins.actionlint
// Cargo clippy
["cargo_clippy"] = Builtins.cargo_clippy
["cargo_clippy"] = (Builtins.cargo_clippy) {
// Skipped under the `ci` profile; CI runs clippy as a dedicated step
profiles = List("!ci")
}
// Cargo format
["cargo_format"] = Builtins.cargo_fmt
["cargo_format"] = (Builtins.cargo_fmt) {
// Skipped under the `ci` profile; CI runs `cargo fmt --check` as a dedicated step
profiles = List("!ci")
}
// Detect accidentally committed private keys
["detect_private_key"] = Builtins.detect_private_key
// Format TOML files
Expand All @@ -25,7 +31,10 @@ local linters = new Mapping<String, Step> {
// Ensure all files end in a new line
["newlines"] = Builtins.newlines
// No commit to protected branches
["no_commit_protected_branch"] = Builtins.no_commit_to_branch
["no_commit_protected_branch"] = (Builtins.no_commit_to_branch) {
// Skipped under the `ci` profile; CI legitimately runs on protected branches
profiles = List("!ci")
}
// Format Pickle files
["pkl_format"] = Builtins.pkl_format
// Lint Pickle files
Expand Down
Loading