Create getArrayMaxValue function#16
Open
Godelvatai wants to merge 2 commits into
Open
Conversation
Created getArrayMaxValue function and setup test cases for the new fucntion
jbb-codes
suggested changes
Jun 7, 2026
There was a problem hiding this comment.
The logic for finding the max value looks correct overall, but there is a bug blocking all tests from passing.
Bug — src/utils/getArrayMaxValue.js, line 13
isArray is a static method on the Array constructor, not an instance method on arrays. This throws a TypeError on every call, including valid inputs.
// Current (broken)
if (!arr.isArray()) {
// Fix
if (!Array.isArray(arr)) {Minor Issues
- Both files are missing a newline at the end of the file. Most editors and linters expect one.
Suggested Improvements
- Handle empty arrays — if [] is passed, Math.max() returns -Infinity. Consider adding a check after the Array.isArray validation and a corresponding unit test.
- Handle arrays with no valid numbers — if every element is a non-number (e.g., ['a', 'b', 'c']), the filter strips everything out and Math.max() again returns -Infinity. Consider validating the filtered result before calling Math.max and adding a unit test for this case.
What's Working
- The
Math.maxwithfilterapproach correctly handles non-number values and zeros. - Test coverage is solid — all four cases are meaningful.
Please fix the Array.isArray call — once corrected, all 4 tests should pass. Requesting changes until then.
Fix to the Array.isArray function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created getArrayMaxValue function and setup test cases for the new fucntion