Skip to content

Allow empty strings as import names for function imports #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreaTP merged 2 commits into from
Jul 6, 2026
Merged

Allow empty strings as import names for function imports #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bee1dd
Remove leftover empty-name check for function imports, already handle…
andreaTP Jul 3, 2026
66804b5
Apply spotless formatting to WasmModuleProcessor
andreaTP Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...tations/processor/src/main/java/run/endive/annotations/processor/WasmModuleProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@

public final class WasmModuleProcessor extends AbstractModuleProcessor {
private static final StandardLocation[] LOCATIONS = {
CLASS_PATH,
ANNOTATION_PROCESSOR_PATH,
SOURCE_PATH,
CLASS_OUTPUT,
CLASS_PATH, ANNOTATION_PROCESSOR_PATH, SOURCE_PATH, CLASS_OUTPUT,
};

@Override
Expand Down
7 changes: 2 additions & 5 deletions wasm/src/main/java/run/endive/wasm/Parser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,16 +679,13 @@ private static ImportSection parseImportSection(ByteBuffer buffer, TypeSection t
String importName = readName(buffer);
ExternalType descType;
try {
descType = ExternalType.byId((int) readVarUInt32(buffer));
descType = ExternalType.byId(readByte(buffer));
} catch (RuntimeException e) {
throw new MalformedException("malformed import kind", e);
}
switch (descType) {
case FUNCTION:
{
if (moduleName.isEmpty() && importName.isEmpty()) {
throw new MalformedException("malformed import kind");
}
importSection.addImport(
new FunctionImport(
moduleName, importName, (int) readVarUInt32(buffer)));
Expand Down Expand Up @@ -860,7 +857,7 @@ private static ExportSection parseExportSection(ByteBuffer buffer) {
// Parse individual functions in the function section
for (int i = 0; i < exportCount; i++) {
var name = readName(buffer, false);
var exportType = ExternalType.byId((int) readVarUInt32(buffer));
var exportType = ExternalType.byId(readByte(buffer));
var index = (int) readVarUInt32(buffer);
exportSection.addExport(new Export(name, index, exportType));
}
Expand Down
Loading