Fix CALL_INDIRECT cross-module type index resolution (#88)#90
Draft
andreaTP wants to merge 1 commit into
Draft
Conversation
…e#88) Type indices are module-local, so CALL_INDIRECT must resolve the caller's type index against the caller's own type section — not the callee's. For same-module calls, nominal type-index comparison is preserved (required for GC subtyping). For cross-module calls, structural FunctionType comparison is used via a new FunctionType.matches() utility.
andreaTP
force-pushed
the
fix/call-indirect-cross-module-type-index
branch
from
2dccab9 to
622659b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #88
Type indices are module-local, so CALL_INDIRECT must resolve the caller's type index against the caller's own type section — not the callee's. For same-module calls, nominal type-index comparison is preserved (required for GC subtyping). For cross-module calls, structural FunctionType comparison is used via a new FunctionType.matches() utility.