Fix LastStores::update for stores without an alias region#13512
Merged
fitzgen merged 2 commits intoMay 29, 2026
Merged
Conversation
Stores without an alias region act like a fence: they clobber all regions. But we additionally need to update `self.last_fence` so that subsequent loads with regions don't get stale values forwarded past the regionless store. Fixes bytecodealliance#13508
cfallin
approved these changes
May 29, 2026
…turn registers for its function signature
fitzgen
deleted the
issue-135080-differential-fuzz-failure-after-alias-regions
branch
yagehu
pushed a commit
to yagehu/wasmtime-x
that referenced
this pull request
Jun 1, 2026
…alliance#13512) * Fix `LastStores::update` for stores without an alias region Stores without an alias region act like a fence: they clobber all regions. But we additionally need to update `self.last_fence` so that subsequent loads with regions don't get stale values forwarded past the regionless store. Fixes bytecodealliance#13508 * Don't run the filetest on architectures that might not have enough return registers for its function signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores without an alias region act like a fence: they clobber all regions. But we additionally need to update
self.last_fenceso that subsequent loads with regions don't get stale values forwarded past the regionless store.Fixes #13508