fix: resolve #13200 — Cranelift: JITMemoryProvider cannot be implemented because JITMemoryKind is private#13517
Open
chinhkrb113 wants to merge 1 commit into
Conversation
…nnot be implemented because JITMemoryKind is private Fixes bytecodealliance#13200 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
github-actions
Bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Making
JITMemoryKindpublic inmemory.rsis not sufficient if it is not re-exported from the crate root alongsideJITMemoryProviderand the other memory-related public items. Downstream users import these symbols fromcranelift_jit::..., so the type needs to be reachable through the same path used forJITMemoryProviderFixes #13200
Changes
cranelift/jit/src/lib.rsWhy
cranelift/jit/src/lib.rs: MakingJITMemoryKindpublic inmemory.rsis not sufficient if it is not re-exported from the crate root alongsideJITMemoryProviderand the other memory-related public items. Downstream users import these symbols fromcranelift_jit::..., so the type needs to be reachable through the same path used forJITMemoryProvider.