Skip to content

refactor: remove obsolete //+build comments#2450

Merged
dboyliao merged 1 commit intoc9s:mainfrom
stringsbuilder:main
Apr 13, 2026
Merged

refactor: remove obsolete //+build comments#2450
dboyliao merged 1 commit intoc9s:mainfrom
stringsbuilder:main

Conversation

@stringsbuilder
Copy link
Copy Markdown
Contributor

@stringsbuilder stringsbuilder commented Apr 9, 2026

The plusbuild analyzer suggests a fix to remove obsolete build tags of the form:

    //+build linux,amd64

in files that also contain a Go 1.18-style tag such as:

    //go:build linux && amd64

(It does not check that the old and new tags are consistent;
that is the job of the 'buildtag' analyzer in the vet suite.)

Signed-off-by: stringsbuilder <stringsbuilder@outlook.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 9, 2026

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.98%. Comparing base (ef2bc66) to head (343d70e).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2450      +/-   ##
==========================================
+ Coverage   19.81%   19.98%   +0.16%     
==========================================
  Files        1090     1103      +13     
  Lines       73700    74605     +905     
==========================================
+ Hits        14604    14910     +306     
- Misses      57764    58336     +572     
- Partials     1332     1359      +27     
Files with missing lines Coverage Δ
pkg/backtest/assets_dummy.go 0.00% <ø> (ø)
pkg/fixedpoint/div128.go 0.00% <ø> (ø)
pkg/util/trylock_18.go 0.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b3bc4...343d70e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dboyliao
Copy link
Copy Markdown
Collaborator

Nice work!
Thanks @stringsbuilder.

@dboyliao dboyliao merged commit cac1440 into c9s:main Apr 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants