fix(stage): stop leaking the private mirror into upstream PRs#48
Merged
Conversation
`stage --pr` (and `issue stage`) appended a footer "Upstreamed from internal review (<url>)" to the upstream PR/issue body, where <url> points at the private mirror. The synthetic fallback body also stated "Staged from a private mirror". Both violate the core principle that the mirror is invisible to upstream. Drop the footer from translateInternalBody (now strips internal blocks only) and reword buildSyntheticBody to a neutral commit summary. The internal PR URL is still recorded in mirror config and shown locally, never sent upstream.
cabljac
force-pushed
the
fix/mirror-invisible-upstream
branch
from
0de5539 to
da3bb0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
venfork stage --prappended a footer to the upstream PR body:That URL points at the private mirror, leaking it into the public upstream PR.
issue stagehad the same leak, and the no-internal-PR fallback body stated "Staged from a private mirror". All violate the core principle: the mirror is invisible to upstream.Fix
translateInternalBody— dropped the footer (and itsinternalUrl/kindparams); now stripsvenfork:internalblocks only. Fixes bothstage --prandissue stage.buildSyntheticBody— reworded "Staged from a private mirror" / "No internal review PR" to a neutral commit summary (Commits in this branch:/No description provided.).The internal PR URL is still recorded in mirror config (
shippedBranches[].internalPrUrl) and shown to you locally — never sent upstream.Tests
tier 3e2e assertion: upstream PR body must not containUpstreamed from internalnor the mirror repo name.bun run checkclean; unit + redaction tests pass.Docs
Updated README
--prstep 2 to drop the footer claim.