Skip to content

docs(ag-ui): fix event-mapping multi-signal effects + FakeAgent/architecture gaps#604

Merged
blove merged 2 commits into
mainfrom
claude/fix-ag-ui-docs
Jun 7, 2026
Merged

docs(ag-ui): fix event-mapping multi-signal effects + FakeAgent/architecture gaps#604
blove merged 2 commits into
mainfrom
claude/fix-ag-ui-docs

Conversation

@blove
Copy link
Copy Markdown
Contributor

@blove blove commented Jun 7, 2026

Summary

Fixes from the ag-ui docs technical review (findings: docs/superpowers/specs/2026-06-06-ag-ui-docs-review-findings.md). The ag-ui docs were in excellent shape — all 5 guides clean, no P0s. Findings clustered in the event-mapping reference, whose "Agent field" column under-reported the AG-UI event reducer's multi-signal effects.

  • P1: CUSTOM row — documented the special on_interrupt case (sets the interrupt signal, resumable; other CUSTOM events emit via events$).
  • P2: RUN_STARTED also clears interrupt; TOOL_CALL_START also updates messages (via parentMessageId); MESSAGES_SNAPSHOT also merges toolCalls (by id); architecture.mdx signals list now includes interrupt; installation.mdx FakeAgent options now include reasoningTokens.

All verified against libs/ag-ui/src/lib/reducer.ts (313-line current version) and fake-agent.ts.

Note: the fix branch was initially cut from a stale local main whose reducer.ts predated the parentMessageId/snapshot-toolCalls handling; rebased onto current origin/main before applying #4/#5, then re-verified end-to-end.

Test Plan

  • Every fix re-verified against its cited source line by an independent reviewer (PASS; all 6, no over-reach, no type="note").
  • All 3 edited ag-ui routes return HTTP 200.

🤖 Generated with Claude Code

@blove blove enabled auto-merge (squash) June 7, 2026 01:46
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadplane Ready Ready Preview, Comment Jun 7, 2026 1:48am

Request Review

@blove blove merged commit f606e68 into main Jun 7, 2026
19 checks passed
blove added a commit that referenced this pull request Jun 7, 2026
* docs(spec): ag-ui docs technical review design

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(plan): ag-ui docs technical review implementation plan

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(ag-ui): technical review findings report

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(ag-ui): mark review findings resolved (PR #604)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant