handshake: avoid expired wildcard cache match on demand#388
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
Signed-off-by: cyphercodes <cyphercodes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384.
When an on-demand handshake for an exact SNI only finds an expired wildcard certificate in the shared cache, do not try to maintain and serve that wildcard certificate. Instead, continue down the exact SNI path: load the exact certificate from storage if present, or obtain one on demand.
This keeps normal wildcard cache reuse unchanged for non-expired wildcard certificates, while preventing an expired wildcard from short-circuiting exact-name issuance.
Tests:
go test ./...go test -run TestGetCertDuringHandshakeExpiredWildcardCacheObtainsExact -count=1 ./