Open
Conversation
malik1004x
reviewed
Apr 13, 2026
| shouldReplace = oldUri?.any((e) => currentNode.uriRaw.contains(e)) ?? true; | ||
| } | ||
|
|
||
| Node? oldDefaultNode = nodes.values.firstWhereOrNull( |
Contributor
There was a problem hiding this comment.
Are you modifying logic for an existing migration? This could potentially break something, especially if you're relying on this migration to run for existing installs as well (which it won't if the user keeps their app up-to-date). If you're just doing changes to still have it compile, that's fine, but generally don't modify old migration logic.
Collaborator
Author
There was a problem hiding this comment.
Its only for the current (in this version) and future runs to be compatible with the new node variables, previous runs won't matter.
malik1004x
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Adds labels to the default nodes, and adds a settings migration for existing installations.
Adds
isDefaultbool to each node to more easily check the default node.Adds
isOfficialbool to each node to know which one is an official Cake node.Adds
isIncludedbool to each node to tag all included app nodes.Pull Request - Checklist