refactor: split debug symbols workflow modules#787
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
I reran the live crash-symbolication smoke from an isolated review worktree because the PR body currently says this was blocked. Validation passed on the existing real simulator crash artifact and matching dSYM:
Please update the PR body to replace the blocked-live-smoke note with this evidence before merge. I am continuing the code review separately. |
f088b32 to
d997d5a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors crash symbolication internals into focused modules for artifact parsing/writing, dSYM UUID discovery and matching, symbolication command execution, compact report shaping, and shared workflow types/utilities while preserving the existing
debug symbolscommand surface and output/artifact contract.Closes #784
Touched files: 7.
Validation
pnpm formatpnpm exec vitest run src/__tests__/debug-symbols.test.ts src/__tests__/cli-debug-symbols.test.ts(15 tests passed)pnpm check:quickpnpm buildnode bin/agent-device.mjs debug symbols --artifact /Users/thymikee/Library/Logs/DiagnosticReports/CrashSymbolProbe-2026-06-11-131543.ips --dsym /private/tmp/agent-device-crash-probe/CrashSymbolProbe.app.dSYM --out /private/tmp/agent-device-pr-787-symbolicated.ipsSymbolicated 3 frames, first actionable frameCrashSymbolProbeTrigger (main.m:8), matched UUID76C74FACC6203472951FEBB0DC7833B5 arm64, full artifact written to/private/tmp/agent-device-pr-787-symbolicated.ips