Repository navigation
fix(website): pin react-dom to match react - #1508
Merged
Merged
Conversation
The website relied on hoisted react/react-dom for @rspress/core's peers. After the catalog moved react to 19.3.0, the lockfile still only had react-dom 19.2.8, so SSG failed with React's version-mismatch check, breaking the Release workflow and the Vercel deploy. Add react-dom to the default catalog next to react and declare both in website/package.json so they always resolve to the same version.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1502, the website build fails in the Release workflow and on Vercel:
websitedidn't declarereact/react-dom, so@rspress/core's peers resolved to whatever the workspace lockfile had. #1502 bumped the catalog'sreactto 19.3.0, but nothing pulled in a matchingreact-dom, so it stayed at 19.2.8.This change:
react-dom: 19.3.0to the default catalog next toreactreactandreact-domascatalog:dependencies inwebsite/package.jsonIn the lockfile,
react-dommoves from 19.2.8 to 19.3.0 everywhere (the Expo testers'expo-routergets the same version).Verified locally:
pnpm install --frozen-lockfileandpnpm buildpass (8/8 tasks, website SSG included).