Skip to content

change protobuf#1

Open
lbeckman314 wants to merge 12 commits into
mainfrom
feature/auth-proto-config
Open

change protobuf#1
lbeckman314 wants to merge 12 commits into
mainfrom
feature/auth-proto-config

Conversation

@lbeckman314

@lbeckman314 lbeckman314 commented May 1, 2025

Copy link
Copy Markdown
Contributor

Overview 🌀

Updates to Funnel Plugin code with updated Protobuf definitions and improved Developer Experience with Makefile improvements.

Credits 🙌

All updates in this PR were made possible by @matthewpeterkort and the Ellrott Lab at OHSU — thank you!

See README.md

Changes proto response to return a proto response structure:
https://github.com/ohsu-comp-bio/funnel/blob/feature/plugins/plugins/proto/plugin.proto#L16-L21

Simplifies config. Passes Task, Config from funnel, to plugin, to test server, back to plugin.

Passes all headers to plugin, test server.

Copilot AI review requested due to automatic review settings May 1, 2025 18:56
@lbeckman314 lbeckman314 added the enhancement New feature or request label May 1, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the protobuf definitions and the corresponding generated code, and aligns the server test code with the new protobuf structure.

  • Updated tests/test-server.go to use a command-line flag for specifying the CSV file and to set AWS configuration fields consistently.
  • Modified proto/auth.proto to replace the simple 'user' and 'host' fields with 'headers' and 'params' map fields.
  • Regenerated protobuf files in Go and Python to reflect the updated schema.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

File Description
tests/test-server.go Introduces CSV file flag and updates AWS configuration assignment in tokenHandler.
proto/auth.proto Replaces string fields with map fields in GetRequest, updating field numbers accordingly.
proto/auth.pb.go Regenerated code reflecting the new GetRequest structure with map entries.
plugin-python/proto/auth_pb2.py Updated generated Python protobuf file to match the changes in auth.proto.
Files not reviewed (1)
  • Makefile: Language not supported
Comments suppressed due to low confidence (1)

proto/auth.pb.go:26

  • [nitpick] This generated code has been updated to match the new proto definition. Please verify that your protobuf generation toolchain is correctly configured to handle the updated schema changes.
Headers       map[string]string      `protobuf:"bytes,3,rep,name=headers,proto3" json:"headers,omitempty" protobuf_key:"bytes,1,opt,name=key" protobuf_val:"bytes,2,opt,name=value"`

Comment thread proto/auth.proto Outdated
@lbeckman314 lbeckman314 moved this from In Progress to Done in Funnel Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants