change protobuf#1
Open
lbeckman314 wants to merge 12 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the protobuf definitions and the corresponding generated code, and aligns the server test code with the new protobuf structure.
- Updated tests/test-server.go to use a command-line flag for specifying the CSV file and to set AWS configuration fields consistently.
- Modified proto/auth.proto to replace the simple 'user' and 'host' fields with 'headers' and 'params' map fields.
- Regenerated protobuf files in Go and Python to reflect the updated schema.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test-server.go | Introduces CSV file flag and updates AWS configuration assignment in tokenHandler. |
| proto/auth.proto | Replaces string fields with map fields in GetRequest, updating field numbers accordingly. |
| proto/auth.pb.go | Regenerated code reflecting the new GetRequest structure with map entries. |
| plugin-python/proto/auth_pb2.py | Updated generated Python protobuf file to match the changes in auth.proto. |
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (1)
proto/auth.pb.go:26
- [nitpick] This generated code has been updated to match the new proto definition. Please verify that your protobuf generation toolchain is correctly configured to handle the updated schema changes.
Headers map[string]string `protobuf:"bytes,3,rep,name=headers,proto3" json:"headers,omitempty" protobuf_key:"bytes,1,opt,name=key" protobuf_val:"bytes,2,opt,name=value"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview 🌀
Updates to Funnel Plugin code with updated Protobuf definitions and improved Developer Experience with Makefile improvements.
Credits 🙌
All updates in this PR were made possible by @matthewpeterkort and the Ellrott Lab at OHSU — thank you!
See README.md
Changes proto response to return a proto response structure:
https://github.com/ohsu-comp-bio/funnel/blob/feature/plugins/plugins/proto/plugin.proto#L16-L21
Simplifies config. Passes Task, Config from funnel, to plugin, to test server, back to plugin.
Passes all headers to plugin, test server.