Add native and RISC-V unit test coverage#452
Open
carlosqwqqwq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
concurrentqueueis already designed as a portable C++11 implementation and does not rely on architecture-specific assembly or SIMD backends in its core queue logic.For this project, the missing part is not a new RISC-V code path in the library itself, but official verification coverage:
riscv64Linux and executed under QEMU without changing the queue algorithm;riscv64support in the README is much more credible if the repository actually runs that verification automatically.This patch keeps the lock-free implementation unchanged and turns the existing portability claim into a reproducible CI-backed test path.
What changed
.github/workflows/ci.yml:ubuntu-latest;g++-riscv64-linux-gnu;riscv64test binary underqemu-riscv64-static.README.md:riscv64Linux under QEMU.Verification
build/bin/unittests.exewith the repository's existing command-line flow;.\build\bin\unittests.exe --disable-prompt --iterations 1;ubuntu:24.04):g++,g++-riscv64-linux-gnu, andqemu-user-static;riscv64Linux cross-compilation and QEMU execution in Docker:build/bin-riscv/unittests-riscv64withriscv64-linux-gnu-g++;qemu-riscv64-static -L /usr/riscv64-linux-gnu;Notes
riscv64verification coverage for an already portable implementation, not to introduce a new RISC-V-specific optimization backend.