Skip to content

Fix Bak Kut Teh tutorial and ATM income display#159

Merged
candour merged 2 commits into
mainfrom
fix-bkt-tutorial-and-atm-display-17455155791418910298
May 16, 2026
Merged

Fix Bak Kut Teh tutorial and ATM income display#159
candour merged 2 commits into
mainfrom
fix-bkt-tutorial-and-atm-display-17455155791418910298

Conversation

@candour

@candour candour commented May 15, 2026

Copy link
Copy Markdown
Owner

This change addresses two minor bugs related to the Bak Kut Teh (BKT) stall boost mechanic.

  1. BKT Tutorial Fix: The tutorial description for the Bak Kut Teh stall incorrectly claimed it provided a 10% boost. The actual game logic and documentation (STALL_STATS.md) specify a 20% base boost. I updated the description in Registry.kt to be accurate.

  2. ATM Display Fix: While ATMs received a passive income boost from adjacent BKT stalls during wave completion, this boosted value was not reflected in the StallConsole UI. I updated StallConsole.kt to apply the damageMultiplier (which represents the power boost) to the ATM's passiveIncome for display purposes.

I also added a record of this fix to fixes.md as FIX-010. Unit tests for BKT logic and stall stats were run and passed.


PR created automatically by Jules for task 17455155791418910298 started by @candour

Summary by CodeRabbit

  • Bug Fixes

    • Corrected Bak Kut Teh stall adjacency boost to 10% (from 20%) for fellow hawkers' stats.
    • Removed incorrect ATM income buffing behavior from Bak Kut Teh stalls.
  • Documentation

    • Updated in-game tutorial descriptions and documentation to reflect accurate Bak Kut Teh mechanics.

Review Change Stack

- Corrected BKT tutorial description to state 20% boost instead of 10%
- Updated StallConsole to display boosted ATM passive income
- Recorded fix in fixes.md

Co-authored-by: candour <4670475+candour@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ff3c55c-e668-4a38-b225-187aca791a0b

📥 Commits

Reviewing files that changed from the base of the PR and between b0114d8 and efd294d.

📒 Files selected for processing (7)
  • AGENTS.md
  • STALL_STATS.md
  • app/src/main/java/com/messark/hawker/MainViewModel.kt
  • app/src/main/java/com/messark/hawker/registry/Registry.kt
  • app/src/main/java/com/messark/hawker/utils/StallUpgradeManager.kt
  • app/src/test/java/com/messark/hawker/BakKutTehSameTickTest.kt
  • fixes.md

📝 Walkthrough

Walkthrough

Bak Kut Teh's adjacency boost stat scaling is reduced from 20% to 10% per level in the upgrade calculation. ATM income calculation removes MEATY damageMultiplier scaling. All related documentation, comparison tables, tests, and fix logs are updated accordingly.

Changes

Bak Kut Teh boost scaling and ATM income correction

Layer / File(s) Summary
Boost stat progression calculation
app/src/main/java/com/messark/hawker/utils/StallUpgradeManager.kt
Per-level "Boost" increment changed from 20.0 to 10.0 in calculateValue.
ATM income decoupling and test validation
app/src/main/java/com/messark/hawker/MainViewModel.kt, app/src/test/java/com/messark/hawker/BakKutTehSameTickTest.kt
ATM income no longer applies MEATY damageMultiplier; test expectations updated from 620 (boosted) to 600 (standard).
Boost documentation and fix tracking
AGENTS.md, STALL_STATS.md, app/src/main/java/com/messark/hawker/registry/Registry.kt, fixes.md
Game rules documentation, stall statistics tables (base, Level 24/36/48 comparisons), tutorial description, and fix entry FIX-010 all updated to reflect 10% per-level boost scaling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • candour/towerpower#132: Both PRs modify MainViewModel.updateGame wave-completion ATM passive income logic for Bak Kut Teh eligibility and payout behavior.
  • candour/towerpower#126: Both PRs modify Bak Kut Teh boost/adjacency handling in MainViewModel and how ATM income uses boost logic.
  • candour/towerpower#157: Both PRs modify Bak Kut Teh scaling and enable/boost behavior in Registry.kt, StallUpgradeManager.kt, and MainViewModel.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix Bak Kut Teh tutorial and ATM income display' accurately and specifically summarizes the two main fixes in the changeset: correcting the BKT tutorial description and fixing the ATM income calculation in the UI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-bkt-tutorial-and-atm-display-17455155791418910298

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@candour

candour commented May 16, 2026

Copy link
Copy Markdown
Owner Author

@jules this is the opposite of correct. Please revert the code changes and instead fix the documentation. ATM stalls do not get buffed, and bak kut teh buffs are 10% per level

@google-labs-jules

Copy link
Copy Markdown
Contributor

@jules this is the opposite of correct. Please revert the code changes and instead fix the documentation. ATM stalls do not get buffed, and bak kut teh buffs are 10% per level

I apologize for the error. I have reverted the ATM income boosting logic and its UI display in StallConsole.kt. I also updated the Bak Kut Teh base boost and upgrade scaling to 10% across the codebase (Registry.kt, StallUpgradeManager.kt) and documentation (STALL_STATS.md, AGENTS.md), and corrected the tutorial descriptions. Tests have been updated to reflect these changes.

- Reverted ATM income boosting logic and UI display
- Set Bak Kut Teh base boost and upgrade increment to 10%
- Updated documentation (STALL_STATS.md, AGENTS.md) and tutorials
- Updated tests to match 10% boost and no ATM buffing

Co-authored-by: candour <4670475+candour@users.noreply.github.com>
@candour
candour merged commit 5257656 into main May 16, 2026
2 of 3 checks passed
@candour
candour deleted the fix-bkt-tutorial-and-atm-display-17455155791418910298 branch May 16, 2026 00:48
@github-actions

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant