Fix Bak Kut Teh tutorial and ATM income display#159
Conversation
- Corrected BKT tutorial description to state 20% boost instead of 10% - Updated StallConsole to display boosted ATM passive income - Recorded fix in fixes.md Co-authored-by: candour <4670475+candour@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughBak Kut Teh's adjacency boost stat scaling is reduced from 20% to 10% per level in the upgrade calculation. ATM income calculation removes MEATY damageMultiplier scaling. All related documentation, comparison tables, tests, and fix logs are updated accordingly. ChangesBak Kut Teh boost scaling and ATM income correction
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Build Successful! 🚀Note: This link will be removed when the PR is closed. |
|
@jules this is the opposite of correct. Please revert the code changes and instead fix the documentation. ATM stalls do not get buffed, and bak kut teh buffs are 10% per level |
I apologize for the error. I have reverted the ATM income boosting logic and its UI display in StallConsole.kt. I also updated the Bak Kut Teh base boost and upgrade scaling to 10% across the codebase (Registry.kt, StallUpgradeManager.kt) and documentation (STALL_STATS.md, AGENTS.md), and corrected the tutorial descriptions. Tests have been updated to reflect these changes. |
- Reverted ATM income boosting logic and UI display - Set Bak Kut Teh base boost and upgrade increment to 10% - Updated documentation (STALL_STATS.md, AGENTS.md) and tutorials - Updated tests to match 10% boost and no ATM buffing Co-authored-by: candour <4670475+candour@users.noreply.github.com>
Build Successful! 🚀Note: This link will be removed when the PR is closed. |
This change addresses two minor bugs related to the Bak Kut Teh (BKT) stall boost mechanic.
BKT Tutorial Fix: The tutorial description for the Bak Kut Teh stall incorrectly claimed it provided a 10% boost. The actual game logic and documentation (STALL_STATS.md) specify a 20% base boost. I updated the description in
Registry.ktto be accurate.ATM Display Fix: While ATMs received a passive income boost from adjacent BKT stalls during wave completion, this boosted value was not reflected in the
StallConsoleUI. I updatedStallConsole.ktto apply thedamageMultiplier(which represents the power boost) to the ATM'spassiveIncomefor display purposes.I also added a record of this fix to
fixes.mdas FIX-010. Unit tests for BKT logic and stall stats were run and passed.PR created automatically by Jules for task 17455155791418910298 started by @candour
Summary by CodeRabbit
Bug Fixes
Documentation