Fix Tiger Mom re-activation and synchronize base stats#200
Conversation
- Fixed logic bug in MainViewModel.kt where Tiger Mom would only buff one ally per lifetime; now resets when target is cleared. - Synchronized Registry.kt base stats with documentation: - Chicken Rice damage: 10f - Durian damage: 150f - Tiger Mom HP: 80f - Enemy HP scaling: 1.07 (7% per wave) - Updated STALL_STATS.md, CUSTOMER_STATS.md, and AGENTS.md for consistency. - Corrected TigerMomBuffCleanupTest.kt to properly initialize GAME screen. - Recorded fix as FIX-017 in fixes.md. Co-authored-by: candour <4670475+candour@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📝 WalkthroughWalkthroughThis PR synchronizes game balance constants in Registry.kt (enemy HP scaling exponent, Chicken Rice/Durian stall damage, Tiger Mom base HP) with corresponding documentation files, and fixes a Tiger Mom buff re-activation bug in MainViewModel by resetting hasActivatedBuff when her buff target is cleared, plus a related test adjustment. ChangesBalance stats and buff fix
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Build Successful! 🚀Note: This link will be removed when the PR is closed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9ded933f-7f69-4a74-bc32-b2510ea9ab32
📒 Files selected for processing (7)
AGENTS.mdCUSTOMER_STATS.mdSTALL_STATS.mdapp/src/main/java/com/messark/hawker/MainViewModel.ktapp/src/main/java/com/messark/hawker/registry/Registry.ktapp/src/test/java/com/messark/hawker/TigerMomBuffCleanupTest.ktfixes.md
| | REF-015 | 2026-07-22 | Refactored `SpatialIndex.kt` and `Registry.kt` for improved efficiency. Optimized spatial bucketing using `floor()`, implemented hex-aware bucket pruning in `findNearby`, and unified `StallBehavior.selectTarget` to consistently use the spatial index, reducing targeting complexity and allocations. | Resolved | | ||
| | REF-016 | 2026-07-25 | Optimized the game engine loop and boost calculation in `MainViewModel.kt` and `Registry.kt`. Removed redundant sorted enemy lists from every tick and introduced a `stallBoosts` cache updated only on grid layout or Bak Kut Teh buff changes. Refactored `selectTarget` to calculate best targets directly from visible candidates, eliminating $O(E \log E)$ sorts per tick. | Resolved | | ||
| | REF-017 | 2026-07-28 | Refactored `MapGenerator.kt` for improved procedural variety. Standardized on axial coordinate logic, implemented a winding path generator (biased random walk) to replace simple A* carving, and introduced clumped pillar placement for more organic-looking environments. | Resolved | | ||
| | FIX-017 | 2026-07-30 | Synchronized base stats and HP scaling in `Registry.kt` and documentation (Chicken Rice damage: 10f, Durian damage: 150f, Tiger Mom HP: 80f, scaling: 1.07). Fixed Tiger Mom re-activation bug in `MainViewModel.kt` by resetting `hasActivatedBuff` when her target is cleared. | Resolved | |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== fixes.md around line 56 =="
cat -n fixes.md | sed -n '45,65p'
echo
echo "== search for date conventions in repository docs =="
rg -n "future-dated|release date|chronolog|FIX-\d+|Resolved" -S --glob '!**/node_modules/**' .
echo
echo "== list other FIX entries with dates =="
rg -n "^\| FIX-" fixes.mdRepository: candour/towerpower
Length of output: 17708
Avoid future-dating FIX-017.
2026-07-30 is later than the rest of this changelog and makes the resolved history look out of order; use the actual fix date instead.
1 participant
I identified and fixed a logic bug where the Tiger Mom enemy type would not re-activate its support behavior after its initial target was removed from the board. I also performed a comprehensive synchronization of base statistics and health scaling factors across the codebase (
Registry.kt) and all documentation files (STALL_STATS.md,CUSTOMER_STATS.md,AGENTS.md) to resolve significant discrepancies. Finally, I updated a unit test and recorded the changes infixes.md.PR created automatically by Jules for task 417701321986501448 started by @candour
Summary by CodeRabbit
Balance Updates
Bug Fixes