Skip to content

Inline Stall Stats and Upgrades UI#97

Merged
candour merged 1 commit into
mainfrom
inline-stall-stats-ui-988043565884886070
Apr 28, 2026
Merged

Inline Stall Stats and Upgrades UI#97
candour merged 1 commit into
mainfrom
inline-stall-stats-ui-988043565884886070

Conversation

@candour

@candour candour commented Apr 28, 2026

Copy link
Copy Markdown
Owner

This change inlines stall upgrade levels and benefit percentages directly into the base statistics display within the selected stall console. Previously, upgrades were listed separately at the bottom. The new format (e.g., "Feed 1 (+20%): 12") highlights improvements in blue while keeping the base labels and values clear. It also handles edge cases like Level 0 (omitting details) and stall-specific terminology (e.g., "Rate" for Tray Return Uncle).


PR created automatically by Jules for task 988043565884886070 started by @candour

Summary by CodeRabbit

  • Refactor
    • Reorganized the stats display interface to integrate upgrade information inline with individual stat values and labels. Upgrade levels and their computed benefits are now displayed with visual styling directly alongside each corresponding stat rather than in a separate dedicated section, providing a more streamlined and visually integrated experience while maintaining full clarity.

- Modified `StatLine` to support `AnnotatedString` labels for inlining levels and benefits.
- Added a `buildInlinedLabel` helper to construct the styled labels (e.g., "Feed 1 (+20%):").
- Removed the redundant separate upgrade details list.
- Restored `labelColor` and added a `String` label overload for `StatLine` to maintain UI consistency and ease of use.
- Corrected category mapping for utility stalls and Tray Return Uncle to ensure upgrade data is retrieved accurately.

Co-authored-by: candour <4670475+candour@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The stats display in StallConsole.kt was refactored to inline upgrade levels and benefits directly into stat labels using AnnotatedString, replacing a separate dedicated upgrades section. A new buildInlinedLabel function constructs these labels with styled upgrade information, and StatLine was extended with an AnnotatedString overload to support the new format.

Changes

Cohort / File(s) Summary
Stats UI Refactoring
app/src/main/java/com/messark/hawker/ui/components/StallConsole.kt
Added buildInlinedLabel function to construct AnnotatedString labels with inline upgrade levels and benefits in blue. Added StatLine overload accepting AnnotatedString parameter. Modified hunger labeling to include derived category names and updated stat lines (Hunger/Range/Rate/Area) to use the new inline-labeled format. Removed prior dedicated upgrades section iteration. Updated existing StatLine to handle annotated labels with trailing colons.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Inline Stall Stats and Upgrades UI' directly and concisely describes the main change: inlining upgrade levels and benefits into the stats display rather than showing them separately.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch inline-stall-stats-ui-988043565884886070

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d4058ece-409e-4c87-b0ec-031246468eca

📥 Commits

Reviewing files that changed from the base of the PR and between 151acf6 and 762e71f.

📒 Files selected for processing (1)
  • app/src/main/java/com/messark/hawker/ui/components/StallConsole.kt

Comment thread app/src/main/java/com/messark/hawker/ui/components/StallConsole.kt
@candour
candour merged commit be60f15 into main Apr 28, 2026
3 checks passed
@candour
candour deleted the inline-stall-stats-ui-988043565884886070 branch April 28, 2026 00:21
This was referenced Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant