Inline Stall Stats and Upgrades UI#97
Conversation
- Modified `StatLine` to support `AnnotatedString` labels for inlining levels and benefits. - Added a `buildInlinedLabel` helper to construct the styled labels (e.g., "Feed 1 (+20%):"). - Removed the redundant separate upgrade details list. - Restored `labelColor` and added a `String` label overload for `StatLine` to maintain UI consistency and ease of use. - Corrected category mapping for utility stalls and Tray Return Uncle to ensure upgrade data is retrieved accurately. Co-authored-by: candour <4670475+candour@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📝 WalkthroughWalkthroughThe stats display in StallConsole.kt was refactored to inline upgrade levels and benefits directly into stat labels using Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Build Successful! 🚀Note: This link will be removed when the PR is closed. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d4058ece-409e-4c87-b0ec-031246468eca
📒 Files selected for processing (1)
app/src/main/java/com/messark/hawker/ui/components/StallConsole.kt
This change inlines stall upgrade levels and benefit percentages directly into the base statistics display within the selected stall console. Previously, upgrades were listed separately at the bottom. The new format (e.g., "Feed 1 (+20%): 12") highlights improvements in blue while keeping the base labels and values clear. It also handles edge cases like Level 0 (omitting details) and stall-specific terminology (e.g., "Rate" for Tray Return Uncle).
PR created automatically by Jules for task 988043565884886070 started by @candour
Summary by CodeRabbit