fix: exclude readme.rst from rendered page and skip Sphinx venv generation#208
Open
himax16 wants to merge 2 commits into
Open
fix: exclude readme.rst from rendered page and skip Sphinx venv generation#208himax16 wants to merge 2 commits into
himax16 wants to merge 2 commits into
Conversation
NickVolynkin
reviewed
Jun 5, 2026
Contributor
There was a problem hiding this comment.
v4 is outdated and generates errors in the output log. It's unrelated to linkcheck errors, but as you're already changing this file, you can fix it along the way.
Suggested change
| uses: actions/checkout@v6 |
Contributor
|
@himax16 I believe the root problem with this link is that the README file is rendered as a documentation page. I doubt that it really should. See on preview: https://canonical-openstack--208.com.readthedocs.build/en/208/readme/. If you agree that it should not, you can exclude it as I did here: https://github.com/canonical/canonical-openstack-docs/pull/210/changes#r3361352344 |
himax16
changed the title
Signed-off-by: Himawan Winarto <himawan.winarto@canonical.com>
…are updated Signed-off-by: Himawan Winarto <himawan.winarto@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude
readme.rstfrom rendered file list and stop Sphinx venv rebuild when configuration files are changed as the CI is no longer maintained.